Skip to content

Skip InPlacePodVerticalScaling and NLB BYO SG conformance tests - #82618

Open
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:skip-conformance-payload-regressions
Open

Skip InPlacePodVerticalScaling and NLB BYO SG conformance tests#82618
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:skip-conformance-payload-regressions

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

Skip upstream OCP payload regressions that produce no ROSA signal:

  • InPlacePodVerticalScaling sig-node tests failing on 4.20/4.22/5.0 nightly payloads (upstream Kubernetes feature regression)
  • cloud-provider-aws NLB BYO Security Group tests failing on 5.0 nightly (upstream cloud-provider-aws regression)

These tests are not ROSA-specific and drag down conformance pass rates without actionable signal.

Affected jobs

  • periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-sts-ovn
  • periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-sts-ovn
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn

Test plan

  • pj-rehearse passes
  • Next conformance run shows fewer failures

Summary by CodeRabbit

  • Updated ROSA AWS HCP and STS conformance workflows to skip failing, non-actionable upstream tests.
  • These skips target InPlace Pod Vertical Scaling and AWS NLB security-group scenarios, reducing noise in nightly ROSA OVN conformance jobs for affected payloads.

Skip upstream OCP payload regressions that produce no ROSA signal:

- InPlacePodVerticalScaling sig-node tests failing on 4.20/4.22/5.0
  nightly payloads (upstream Kubernetes feature regression)
- cloud-provider-aws NLB BYO Security Group tests failing on 5.0
  nightly (upstream cloud-provider-aws regression)
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 860c2136-6a3f-4224-bca1-fbfce6d7aa2f

📥 Commits

Reviewing files that changed from the base of the PR and between 811465a and 616ede9.

📒 Files selected for processing (2)
  • ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml
  • ci-operator/step-registry/rosa/aws/sts/conformance/rosa-aws-sts-conformance-workflow.yaml

Walkthrough

The ROSA HCP and STS conformance workflows update their TEST_SKIPS lists with additional security-group, network-segmentation, and InPlace Resize Container patterns.

Changes

ROSA conformance skip configuration

Layer / File(s) Summary
Update conformance test skips
ci-operator/step-registry/rosa/aws/{hcp,sts}/conformance/*
The HCP workflow replaces one skip with four security-group and resize patterns, while the STS workflow updates network-segmentation formatting and adds the resize skip.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change by describing added skips for InPlacePodVerticalScaling and NLB BYO SG conformance tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Touched files only update static TEST_SKIPS YAML entries; no Ginkgo titles or dynamic values were added.
Test Structure And Quality ✅ Passed PR only changes YAML skip lists; no Ginkgo test code, setup/cleanup, or assertions were modified.
Microshift Test Compatibility ✅ Passed PASS: The PR only edits YAML skip lists in ROSA conformance workflows; it adds no new Ginkgo tests or MicroShift-relevant code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests were added or modified; the PR only changes CI workflow skip lists in YAML, so the SNO test check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only TEST_SKIPS entries changed in workflow YAML; no scheduling constraints, replicas, affinity, or topology assumptions were introduced.
Ote Binary Stdout Contract ✅ Passed PR only edits two workflow YAML skip lists; no Go/binary setup code or stdout writes in main/suite init were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only edits TEST_SKIPS in workflow YAML; it adds no new Ginkgo tests or networking code, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed The patch only edits YAML test-skip lists; no weak-crypto algorithms, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed PR only edits workflow TEST_SKIPS lists; no privileged/root/host* or allowPrivilegeEscalation settings appear in changed files.
No-Sensitive-Data-In-Logs ✅ Passed The PR only updates TEST_SKIPS entries in two YAML workflow files; no log statements, secrets, or PII are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bmeng and joshbranham July 29, 2026 14:47
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-operator-framework-olm-release-4.22-periodics-e2e-rosa-sts-ovn-extended-f3 616ede9 link unknown /pj-rehearse periodic-ci-openshift-operator-framework-olm-release-4.22-periodics-e2e-rosa-sts-ovn-extended-f3
ci/rehearse/periodic-ci-openshift-operator-framework-operator-controller-release-4.23-periodics-e2e-rosa-sts-ovn-slow-extended-f3 616ede9 link unknown /pj-rehearse periodic-ci-openshift-operator-framework-operator-controller-release-4.23-periodics-e2e-rosa-sts-ovn-slow-extended-f3
ci/rehearse/periodic-ci-openshift-operator-framework-operator-controller-release-4.21-periodics-e2e-rosa-sts-ovn-slow-extended-f3 616ede9 link unknown /pj-rehearse periodic-ci-openshift-operator-framework-operator-controller-release-4.21-periodics-e2e-rosa-sts-ovn-slow-extended-f3
ci/rehearse/periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-rosa-sts-ovn-extended-f3 616ede9 link unknown /pj-rehearse periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-rosa-sts-ovn-extended-f3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant