Skip to content

ROSAENG-62569: enable the monitoring tests - #82587

Open
bmeng wants to merge 1 commit into
openshift:mainfrom
bmeng:enable-monitoring
Open

ROSAENG-62569: enable the monitoring tests#82587
bmeng wants to merge 1 commit into
openshift:mainfrom
bmeng:enable-monitoring

Conversation

@bmeng

@bmeng bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixed the hypershift management cluster missing env issue in #82458

Enable the monitoring test to see if it is working.

As we need access to the management cluster, bind the sector to the rosa-e2e with us-west-2 for now so that we have access as the other rosa-e2e jobs.

Summary by CodeRabbit

  • Updated the ROSA AWS HCP conformance prow workflow (ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml) to run monitoring coverage in the HyperShift management cluster flow by removing the prior SKIP_MONITOR_TEST: "true" override (while keeping the existing TEST_SKIPS exclusions as-is).
  • Set workflow environment values CLUSTER_SECTOR: rosa-e2e and REGION: us-west-2.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@bmeng: This pull request references ROSAENG-62569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Fixed the hypershift management cluster missing env issue in #82458

Enable the monitoring test to see if it is working.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from jfrazierRedHat and ravitri July 29, 2026 00:04
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The ROSA AWS HCP conformance workflow sets CLUSTER_SECTOR: rosa-e2e and REGION: us-west-2, removes SKIP_MONITOR_TEST: "true", and retains existing test exclusions and environment entries.

Changes

ROSA HCP conformance workflow

Layer / File(s) Summary
Update conformance workflow environment
ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml
Adds sector and region variables, removes the monitor test skip, and leaves existing test exclusions and replica settings unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: ravitri, jfrazierredhat

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates a workflow YAML env block; no Ginkgo test titles or dynamic test names were added or changed.
Test Structure And Quality ✅ Passed PR only changes a workflow YAML; no Ginkgo test code or test structure to review.
Microshift Test Compatibility ✅ Passed Only a workflow YAML env change was made; no new Ginkgo tests or OpenShift API usages were added, so MicroShift compatibility is not impacted.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo test code was added or changed; this PR only edits CI workflow env vars and removes a monitor-failure skip, so the SNO test check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only workflow env vars changed; no manifests/controllers or topology-sensitive scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only a workflow YAML env block changed; no process-level code or stdout writes were added, so the stdout contract isn’t implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a workflow env update was made; no new Ginkgo e2e test code or external-connectivity logic was added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed Diff only adds CLUSTER_SECTOR/REGION and removes SKIP_MONITOR_TEST; no weak-crypto or custom-crypto code appears.
Container-Privileges ✅ Passed Only env vars changed in the workflow YAML; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed The workflow change only adjusts env vars and removes a test skip; it adds no logging or sensitive identifiers.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: it enables monitoring tests by removing the skip flag.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng
bmeng force-pushed the enable-monitoring branch from f732b37 to 7d7b775 Compare July 29, 2026 08:11
@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng
bmeng force-pushed the enable-monitoring branch from 7d7b775 to 96eaa03 Compare July 29, 2026 23:50
@bmeng

bmeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bmeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.19-e2e-rosa-hcp-ovn N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bmeng

bmeng commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@bmeng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn 96eaa03 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn 96eaa03 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn 96eaa03 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn 96eaa03 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants