OCPBUGS-92035: Allow to customize internal hardcoded timeouts - #81028
OCPBUGS-92035: Allow to customize internal hardcoded timeouts#81028pawanpinjarkar wants to merge 1 commit into
Conversation
openshift-ci-robot
added
jira/severity-important
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-92035, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughHard-coded timeout values ( ChangesDevscripts Timeout Parameterization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-92035, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 4380 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse auto-ack |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This has been addressed in #82635. |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The existing timeouts are hardcoded to arbitrary values, making it impossible to adjust them for specific jobs or use cases. This PR introduces two new environment variables to allow customization:
Both variables fall back to their historical default values when not defined, ensuring backward compatibility.
Summary by CodeRabbit
This change makes two dev-scripts timeouts configurable through CI environment variables instead of being fixed in the setup scripts. In practice, OpenShift CI jobs that run these dev-scripts flows can now tune both the overall setup duration and the timeout for the target step without editing the scripts themselves.
It updates the baremetalds devscripts setup flow to:
DEVSCRIPTS_TIMEOUTfor the mainssh ... bashexecution timeoutDEVSCRIPTS_TARGET_TIMEOUTfor themake ${DEVSCRIPTS_TARGET}timeoutThe agent E2E conformance workflow also sets a longer target timeout for the
agentdev-scripts target, which helps accommodate longer-running execution in that CI path.Backward compatibility is preserved by keeping the existing default timeout values when the variables are not provided.