ROSAENG-57139 | ci: Replace terraform-provider-rhcs unit job with pre-push-checks#80765
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe CI configuration for ChangesRHCS CI configuration refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
amandahla
force-pushed
the
ROSAENG-57139-pre-push-checks
branch
from
9e7f743 to
784d2c3
Compare
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Use Dockerfile.clients for the main presubmit gate, require ci/prow/pre-push-checks on main, and skip presubmits when only markdown or doc-only paths change. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
amandahla
force-pushed
the
ROSAENG-57139-pre-push-checks
branch
from
784d2c3 to
e2cc22b
Compare
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 47 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-terraform-redhat-terraform-provider-rhcs-main-pre-push-checks |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amandahla: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/rehearse/periodic-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-rosa-classic-full-resource-f7 failure is not related to this PR |
|
@amandahla: amandahla unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse skip |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
Why periodic-ci-…-e2e-rosa-classic-full-resource-f7 (and similar e2e rehearsals) can be ignored for this PR pj-rehearse flags this job because the PR regenerates the e2e variant (__e2e.yaml, __e2e-presubmits.yaml, main-periodics.yaml) when adding shared skip_if_only_changed rules — not because this periodic is part of the pre-push-checks migration. That rehearsal runs a full AWS ROSA Classic e2e using build/ci-tf-e2e.Dockerfile / rhcs-tf-e2e. It does not exercise Dockerfile.clients, make pre-push-checks, or the new merge gate. The changes under review for this PR are validated by: rehearse-…-pull-ci-…-pre-push-checks |
|
/override ci/rehearse/periodic-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-rosa-classic-full-resource-f7 |
|
@jerichokeyne: jerichokeyne unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, jerichokeyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/skip periodic-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-rosa-classic-full-resource-f7 |
|
/pj-rehearse skip |
|
@jerichokeyne: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
merged commit fd55025
into
openshift:main
|
@amandahla: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Summary
unitpresubmit onterraform-redhat/terraform-provider-rhcsmainwithpre-push-checks, runningmake pre-push-checksin aDockerfile.clientsimage (terraform-provider-rhcs-clients).ci/prow/pre-push-checksto branch protection required contexts formain(append-only; no other contexts removed).skip_if_only_changedon all main presubmits (including e2e image builds and e2e test jobs) so PRs that only change markdown or other doc-only paths do not trigger Prow jobs.Test plan
make jobs WHAT=terraform-redhat/terraform-provider-rhcsmake jobs)ci/prow/pre-push-checksruns and is requiredci/prow/unitoff GitHub required checks if still listed (job removed)Dependencies
Requires
Dockerfile.clientsandmake pre-push-checksonterraform-redhat/terraform-provider-rhcsmain(already merged).Made with Cursor
Summary by CodeRabbit
This PR updates the CI/CD infrastructure for the
terraform-redhat/terraform-provider-rhcsrepository to replace the unit test job with a new pre-push-checks job and adds skip conditions for documentation-only changes across all presubmits.Key Changes:
Unit Test Job Replacement - The
unitpresubmit job in the main CI configuration is replaced with a newpre-push-checksjob that executesmake pre-push-checkswithin aterraform-provider-rhcs-clientscontainer image (built fromDockerfile.clients).Branch Protection Requirement - The new
ci/prow/pre-push-checksjob is added as a required status check for themainbranch, ensuring it must pass before merging.Skip Documentation-Only Changes - All main presubmits (including e2e image builds and e2e test jobs) are now configured to skip execution when PRs only modify documentation and metadata files. This prevents unnecessary CI runs for changes to markdown files,
LICENSE,OWNERS,.goreleaser.yaml, renovate configs, and documentation directories.The changes maintain the same validation behavior while consolidating checks into a single pre-push-checks target and reducing CI noise for documentation-only PRs. The implementation depends on
Dockerfile.clientsand themake pre-push-checkstarget already being available on the repository's main branch.