Enable cluster-update-console-plugin image promotion for 5.0#80758
Enable cluster-update-console-plugin image promotion for 5.0#80758jhadvig wants to merge 1 commit into
Conversation
WalkthroughRemoves the ChangesEnable 5.0 Promotion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhadvig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-update-console-plugin/openshift-cluster-update-console-plugin-release-5.0.yaml`:
- Around line 7-10: The promotion configuration added to the release-5.0 config
violates the promotion guard validator rule that only main/master configs should
promote to the current release. Remove the promotion block (the lines promoting
to ocp/5.0) from openshift-cluster-update-console-plugin-release-5.0.yaml, as
the openshift-cluster-update-console-plugin-main.yaml config already handles
promotions to ocp/5.0 with disabled=False. If additional promotion configuration
is needed to resolve image availability issues, make those changes in the main
config file instead of the release branch config.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 59eaaed2-2ff7-44fe-ba8c-46454ddc3b75
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-update-console-plugin/openshift-cluster-update-console-plugin-release-5.0.yaml
| promotion: | ||
| to: | ||
| - disabled: true | ||
| name: "5.0" | ||
| - name: "5.0" | ||
| namespace: ocp |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check for main/master config that would conflict with this release-5.0 promotion
BASE_DIR="ci-operator/config/openshift/cluster-update-console-plugin"
# Check if main or master config exists
echo "=== Checking for main/master configs ==="
fd -t f 'openshift-cluster-update-console-plugin-(main|master)\.yaml$' "$BASE_DIR"
# If found, check their promotion targets
for config in "$BASE_DIR"/openshift-cluster-update-console-plugin-{main,master}.yaml; do
if [[ -f "$config" ]]; then
echo "=== Checking promotion in $(basename "$config") ==="
# Extract promotion.to[] entries
python3 -c "
import yaml, sys
with open('$config') as f:
data = yaml.safe_load(f)
promo = data.get('promotion', {}).get('to', [])
for entry in promo:
name = entry.get('name', '')
ns = entry.get('namespace', 'ocp')
disabled = entry.get('disabled', False)
print(f'{ns}/{name} (disabled={disabled})')
"
fi
done
# Run the promotion guard validator
echo "=== Running promotion guard validator ==="
python3 hack/validate-main-promotion-guard.pyRepository: openshift/release
Length of output: 1582
Revert promotion change; it violates the promotion guard validator.
The release-5.0 config cannot promote to ocp/5.0 because the main config already does. The promotion guard validator explicitly forbids this pattern:
ERROR: Main/master must promote to current release only; release-5.0 configs must have promotion disabled.
main/master -> ocp/5.0, ocp-private/5.0-priv. release-5.0 / openshift-5.0 -> promotion disabled.
The openshift-cluster-update-console-plugin-main.yaml config already promotes to ocp/5.0 with disabled=False. Removing disabled: true from the release-5.0 config violates the rule that only main/master should promote to the current release.
If additional promotion configuration is needed to fix the image availability issue, it should be made in the main config, not in the release branch config.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cluster-update-console-plugin/openshift-cluster-update-console-plugin-release-5.0.yaml`
around lines 7 - 10, The promotion configuration added to the release-5.0 config
violates the promotion guard validator rule that only main/master configs should
promote to the current release. Remove the promotion block (the lines promoting
to ocp/5.0) from openshift-cluster-update-console-plugin-release-5.0.yaml, as
the openshift-cluster-update-console-plugin-main.yaml config already handles
promotions to ocp/5.0 with disabled=False. If additional promotion configuration
is needed to resolve image availability issues, make those changes in the main
config file instead of the release branch config.
|
@jhadvig: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
The cluster-update-console-plugin image promotion to the ocp/5.0 imagestream is currently disabled. Without promotion, the built image is never published to the release imagestream, so oc adm release new has no real image to include in the release payload.
This causes the console plugin deployment to crash-loop on TechPreview clusters because the image in the release is stale/invalid.
Related:
Summary by CodeRabbit
This PR enables image promotion for the cluster-update-console-plugin in the OpenShift CI infrastructure. The change modifies the CI configuration for the 5.0 release entry by removing the
disabled: trueflag from the promotion section, activating the promotion mechanism that was previously dormant.Practical impact: With this change, built cluster-update-console-plugin images will now be automatically promoted to the ocp/5.0 imagestream, making them available for inclusion in release payloads. This resolves the current issue where TechPreview clusters experience console plugin deployment crashes due to unavailable or stale images being referenced in the release.