Skip to content

Use .ci-operator.yaml from rhobs/observability#80474

Open
simonpasquier wants to merge 1 commit into
openshift:mainfrom
simonpasquier:use-ci-operator-build-from-repo
Open

Use .ci-operator.yaml from rhobs/observability#80474
simonpasquier wants to merge 1 commit into
openshift:mainfrom
simonpasquier:use-ci-operator-build-from-repo

Conversation

@simonpasquier

@simonpasquier simonpasquier commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates the ci-operator configuration for the RHOBS observability operator in the OpenShift CI infrastructure, shifting responsibility for the build definition to the rhobs/observability source repository.

Key changes

  • In ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml, build_root.from_repository is set to true, so ci-operator will source the build/root definition from the repository’s .ci-operator.yaml.
  • The previously hardcoded image_stream_tag under build_root is removed, since the build inputs are now expected from the source repository.

Impact

  • Decouples this operator’s CI/build configuration from the centralized openshift/release settings, enabling the RHOBS team to manage build behavior directly in their own repo.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The CI build configuration for the observability-operator is updated to set from_repository: true in the build root, replacing the previous external image stream tag reference to the OpenShift release stream.

Changes

Build root configuration update

Layer / File(s) Summary
Build root configuration update
ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml
The build_root is configured with from_repository: true, removing the prior image_stream_tag definition that referenced the release stream in the openshift namespace with an RHEL-9 golang/OpenShift 4.20 tag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies CI operator configuration YAML files in the openshift/release repository. This repository contains CI/CD infrastructure configuration, not application tests. No Ginkgo tests exist i...
Test Structure And Quality ✅ Passed PR modifies CI/CD configuration YAML files only, containing no Ginkgo test code. Custom check for test structure is not applicable to YAML config files.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The changes are CI configuration only (modifying build_root in YAML files), so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI operator YAML configuration for rhobs/observability-operator; no new Ginkgo e2e tests are added. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only CI operator configuration file (ci-operator/config/...), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML files; no OTE binary source code or stdout behavior was changed, making the check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only CI operator configuration (YAML), not adding any Ginkgo e2e test code, so the check is not applicable.
No-Weak-Crypto ✅ Passed No weak cryptography detected. The PR only modifies a YAML CI operator configuration file with no crypto-related code or implementations.
Container-Privileges ✅ Passed CI operator config file contains no privileged container settings: no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN capability, root execution, or allowPrivilegeEscalation: true.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies a CI/CD configuration file; no sensitive data (passwords, tokens, API keys, PII, credentials) is logged or exposed in the changes or existing code.
Title check ✅ Passed The title accurately describes the main change: updating build_root to use from_repository: true to leverage the .ci-operator.yaml from the rhobs/observability repository.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier force-pushed the use-ci-operator-build-from-repo branch from 4106fad to a4bc26e Compare June 15, 2026 09:00
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rhobs-observability-operator-main-ci-index-observability-bundle rhobs/observability-operator presubmit Ci-operator config changed
pull-ci-rhobs-observability-operator-main-images rhobs/observability-operator presubmit Ci-operator config changed
pull-ci-rhobs-observability-operator-main-observability-operator-e2e rhobs/observability-operator presubmit Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.14-azure-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.17-gcp-coo-stage-dast N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-gcp-interop-coo-production N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.22-gcp-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.12-azure-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-arm64-ocp-4.16-gcp-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-upstream-ocp-4.19-aws-coo-compat N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.18-gcp-coo-stage N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@simonpasquier

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-rhobs-observability-operator-main-images

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@simonpasquier simonpasquier changed the title [WIP] Use .ci-operator.yaml from rhobs/observability Use .ci-operator.yaml from rhobs/observability Jun 15, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2026
@simonpasquier

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-rhobs-observability-operator-main-observability-operator-e2e
/pj-rehearse pull-ci-rhobs-observability-operator-main-ci-index-observability-bundle

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@simonpasquier

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-rhobs-observability-operator-main-ci-index-observability-bundle

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonpasquier

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant