OLS-3210: Remove pf5/4-19 console images from related_images.json and bundle#1730
Conversation
|
@blublinsky: This pull request references OLS-3210 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ClusterServiceVersion manifest updates the TLS certificate secret reference CRD description to clarify behavior when the optional ChangesCSV Manifest: Console Plugin Consolidation
Tekton Pipeline Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0884eb4 to
ab7b72d
Compare
ab7b72d to
a3e5cbd
Compare
a3e5cbd to
fcfc033
Compare
|
@blublinsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blublinsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Summary
Bundle follow-up for OLS-3210 / epic OLS-3205: align the OLM bundle with the single-console-image operator merged in #1705.
Operator code no longer accepts --console-image-pf5 or --console-image-4-19. The CSV still passed those flags and listed pf5/4-19 in relatedImages, which caused OLM installs to CrashLoop. This PR updates related_images.json and regenerates the bundle.
Changes
Remove lightspeed-console-plugin-pf5 and lightspeed-console-plugin-4-19 from related_images.json
Regenerate bundle (make bundle BUNDLE_TAG=1.1.1):
Drop --console-image-pf5 and --console-image-4-19 from the operator deployment args in the CSV
Drop pf5/4-19 entries from spec.relatedImages
Keep a single --console-image and lightspeed-console-plugin related imageSummary
Bundle follow-up for OLS-3210 / epic OLS-3205: align the OLM bundle with the single-console-image operator merged in #1705.
Operator code no longer accepts --console-image-pf5 or --console-image-4-19. The CSV still passed those flags and listed pf5/4-19 in relatedImages, which caused OLM installs to CrashLoop. This PR updates related_images.json and regenerates the bundle.
Changes
Remove lightspeed-console-plugin-pf5 and lightspeed-console-plugin-4-19 from related_images.json
Regenerate bundle (make bundle BUNDLE_TAG=1.1.1):
Drop --console-image-pf5 and --console-image-4-19 from the operator deployment args in the CSV
Drop pf5/4-19 entries from spec.relatedImages
Keep a single --console-image and lightspeed-console-plugin related image
Type of change
Related Tickets & Documents
https://redhat.atlassian.net/browse/OLS-3210
https://redhat.atlassian.net/browse/OLS-3210
Checklist before requesting a review
Testing
Summary by CodeRabbit
KeyCertSecretRefwhen the optionalca.crtkey is not present.