OLS-3212: Remove pf5/419 Konflux artifacts and obsolete Cypress console pipeline#1734
Conversation
|
@blublinsky: This pull request references OLS-3212 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughThe PR removes two Tekton Pipeline manifests ( ChangesPF5/4.19 Console Plugin Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'm unsure about removing the pf6 pipeline. I mean, we will still need to test it in bundle right? We just need to adapt it. I'm unsure we don't want the same with pf5 and 4.19 (even though the latter doesn't exist yet). |
We needed to remove it as it is wrong - Cypress-based. We need a completely new one based on the existing tests in the console. Similar to what we are doing for the server |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blublinsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@blublinsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Summary
Decommission legacy multi-console Konflux infrastructure in the operator repo as part of OLS-3205 / OLS-3212.
After the single console image change (#1705) and bundle follow-up (#1730), this PR removes remaining repo references to the retired
lightspeed-console-pf5andlightspeed-console-4-19build components and deletes obsolete Cypress-based console e2e pipelines fromols-bundle.Changes:
hack/snapshot_to_image_list.sh— emit onlylightspeed-console-pluginfrom thelightspeed-consolesnapshot component (drop pf5/4-19 jq, registry remapping, and JSON entries)config/manager/imagedigestmirrorset.yaml— remove pf5 image digest mirror.tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf5.yaml.tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf6.yaml.tekton/integration-tests/scripts/run-console-cypress-tests.sh(console repo uses Playwright; Cypress config no longer exists)Type of change
Related Tickets & Documents
https://redhat.atlassian.net/browse/OLS-3212
https://redhat.atlassian.net/browse/OLS-3212
Checklist before requesting a review
Testing
Summary by CodeRabbit