Skip to content

OLS-3212: Remove pf5/419 Konflux artifacts and obsolete Cypress console pipeline#1734

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
blublinsky:remove-pf5-419
Jun 19, 2026
Merged

OLS-3212: Remove pf5/419 Konflux artifacts and obsolete Cypress console pipeline#1734
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
blublinsky:remove-pf5-419

Conversation

@blublinsky

@blublinsky blublinsky commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description

Summary
Decommission legacy multi-console Konflux infrastructure in the operator repo as part of OLS-3205 / OLS-3212.
After the single console image change (#1705) and bundle follow-up (#1730), this PR removes remaining repo references to the retired lightspeed-console-pf5 and lightspeed-console-4-19 build components and deletes obsolete Cypress-based console e2e pipelines from ols-bundle.

Changes:

  • hack/snapshot_to_image_list.sh — emit only lightspeed-console-plugin from the lightspeed-console snapshot component (drop pf5/4-19 jq, registry remapping, and JSON entries)
  • config/manager/imagedigestmirrorset.yaml — remove pf5 image digest mirror
  • Delete .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf5.yaml
  • Delete .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf6.yaml
  • Delete .tekton/integration-tests/scripts/run-console-cypress-tests.sh (console repo uses Playwright; Cypress config no longer exists)

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Removed PatternFly 5 (PF5) specific console testing infrastructure, including related end-to-end test pipelines and execution scripts.
    • Simplified console plugin image mirroring configuration to use unified image references instead of PF5-specific variants.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 18, 2026

Copy link
Copy Markdown

@blublinsky: This pull request references OLS-3212 which is a valid jira issue.

Details

In response to this:

Description

Summary
Decommission legacy multi-console Konflux infrastructure in the operator repo as part of OLS-3205 / OLS-3212.
After the single console image change (#1705) and bundle follow-up (#1730), this PR removes remaining repo references to the retired lightspeed-console-pf5 and lightspeed-console-4-19 build components and deletes obsolete Cypress-based console e2e pipelines from ols-bundle.

Changes:

  • hack/snapshot_to_image_list.sh — emit only lightspeed-console-plugin from the lightspeed-console snapshot component (drop pf5/4-19 jq, registry remapping, and JSON entries)
  • config/manager/imagedigestmirrorset.yaml — remove pf5 image digest mirror
  • Delete .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf5.yaml
  • Delete .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf6.yaml
  • Delete .tekton/integration-tests/scripts/run-console-cypress-tests.sh (console repo uses Playwright; Cypress config no longer exists)

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c81bb6e5-bc2e-4fe8-9b62-32a97d6f63dd

📥 Commits

Reviewing files that changed from the base of the PR and between 46fb490 and 620ea56.

📒 Files selected for processing (5)
  • .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf5.yaml
  • .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf6.yaml
  • .tekton/integration-tests/scripts/run-console-cypress-tests.sh
  • config/manager/imagedigestmirrorset.yaml
  • hack/snapshot_to_image_list.sh
💤 Files with no reviewable changes (5)
  • .tekton/integration-tests/scripts/run-console-cypress-tests.sh
  • config/manager/imagedigestmirrorset.yaml
  • .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf5.yaml
  • .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf6.yaml
  • hack/snapshot_to_image_list.sh

📝 Walkthrough

Walkthrough

The PR removes two Tekton Pipeline manifests (pf5 and pf6 variants) for console Cypress e2e testing, the run-console-cypress-tests.sh runner script, and strips all PF5 and 4.19 console-plugin image references from the ImageDigestMirrorSet config and the snapshot_to_image_list.sh script.

Changes

PF5/4.19 Console Plugin Removal

Layer / File(s) Summary
Remove Tekton e2e pipeline manifests and Cypress runner
.tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf5.yaml, .tekton/integration-tests/pipelines/lightspeed-console-e2e-test-pipeline-pf6.yaml, .tekton/integration-tests/scripts/run-console-cypress-tests.sh
Both ols-console-pre-commits pipeline definitions (pf5 and pf6 variants, 279 lines each) are fully deleted, along with the 95-line Cypress runner script that cloned the console repo, installed Cypress, ran tests, retried on failure, and wrote exit code/artifacts.
Strip PF5/4.19 console plugin from image mirror config and snapshot script
config/manager/imagedigestmirrorset.yaml, hack/snapshot_to_image_list.sh
ImageDigestMirrorSet replaces the lightspeed-console-plugin-pf5-rhel9 mirror with lightspeed-console-plugin-rhel9. snapshot_to_image_list.sh removes PF5 and 4.19 console-plugin image extraction, preview/stable registry rewriting, and their RELATED_IMAGES JSON entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/lightspeed-operator#1705: Removes PF5/4.19 console image selection flags and default image constants from the operator, directly related to the PF5 console-plugin cleanup performed in this PR.

Suggested reviewers

  • raptorsun
  • xrajesh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main changes: removing pf5/4-19 Konflux artifacts and the obsolete Cypress console pipeline, which matches the primary objectives of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bparees and xrajesh June 18, 2026 13:43
@JoaoFula

Copy link
Copy Markdown
Contributor

I'm unsure about removing the pf6 pipeline. I mean, we will still need to test it in bundle right? We just need to adapt it. I'm unsure we don't want the same with pf5 and 4.19 (even though the latter doesn't exist yet).

@blublinsky

Copy link
Copy Markdown
Contributor Author

I'm unsure about removing the pf6 pipeline. I mean, we will still need to test it in a bundle, right? We just need to adapt it. I'm unsure we don't want the same with pf5 and 4.19 (even though the latter doesn't exist yet).

We needed to remove it as it is wrong - Cypress-based. We need a completely new one based on the existing tests in the console. Similar to what we are doing for the server

@JoaoFula

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@blublinsky

Copy link
Copy Markdown
Contributor Author

/approve

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blublinsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2026
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 64beb4e into openshift:main Jun 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants