Skip to content

Team Maps Expansion: New team spawnzones for multiple maps#4058

Merged
evanpelle merged 2 commits into
openfrontio:mainfrom
RickD004:team-maps
May 28, 2026
Merged

Team Maps Expansion: New team spawnzones for multiple maps#4058
evanpelle merged 2 commits into
openfrontio:mainfrom
RickD004:team-maps

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

Description:

Lets give Teams and HvN gamemodes some attention. Adds team spawnzones to the following maps, and boosts them to appear more frequently as this gamemode:

  • Straitofgibraltar - 2 teams
  • Aegean - 2 teams
  • Beringsea - 2 teams
  • Beringstrait - 2 teams
  • Bosphorusstraits - 2 teams
  • Conakry - 2 teams
  • Falklandislands - 2 teams
  • Straitofhormuz - 2 teams
  • Tradersdream - 2 teams
  • Surrounded - 2 teams & 4 teams
  • Pluto - 2 teams
  • Gulf of St. Lawrence - 3 teams

These maps (especially the ones for 2 teams) are all very symmetrical and would be nice gift for the playerbase, which enjoys these kind of games like FourIslands4Teams and Baikal2Teams. This is also nice for HvN, as it centralizes the players and gives them a better chance at defeating the nations.

Screenshots of the maps with the new team spawnzones:

Captura de pantalla 2026-05-28 001558 Captura de pantalla 2026-05-28 001913 Captura de pantalla 2026-05-28 002032 Captura de pantalla 2026-05-28 002348 Captura de pantalla 2026-05-28 002704 Captura de pantalla 2026-05-28 002859 Captura de pantalla 2026-05-28 003134 Captura de pantalla 2026-05-28 003449 Captura de pantalla 2026-05-28 003650 Captura de pantalla 2026-05-28 003951 Captura de pantalla 2026-05-28 004632 Captura de pantalla 2026-05-28 005518 Captura de pantalla 2026-05-28 000505

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfec8a99-a03a-46f8-a7ed-866ebfddd924

📥 Commits

Reviewing files that changed from the base of the PR and between a5e28d8 and 7ead238.

📒 Files selected for processing (25)
  • map-generator/assets/maps/aegean/info.json
  • map-generator/assets/maps/beringsea/info.json
  • map-generator/assets/maps/beringstrait/info.json
  • map-generator/assets/maps/bosphorusstraits/info.json
  • map-generator/assets/maps/conakry/info.json
  • map-generator/assets/maps/falklandislands/info.json
  • map-generator/assets/maps/gulfofstlawrence/info.json
  • map-generator/assets/maps/pluto/info.json
  • map-generator/assets/maps/straitofgibraltar/info.json
  • map-generator/assets/maps/straitofhormuz/info.json
  • map-generator/assets/maps/surrounded/info.json
  • map-generator/assets/maps/tradersdream/info.json
  • resources/maps/aegean/manifest.json
  • resources/maps/beringsea/manifest.json
  • resources/maps/beringstrait/manifest.json
  • resources/maps/bosphorusstraits/manifest.json
  • resources/maps/conakry/manifest.json
  • resources/maps/falklandislands/manifest.json
  • resources/maps/gulfofstlawrence/manifest.json
  • resources/maps/pluto/manifest.json
  • resources/maps/straitofgibraltar/manifest.json
  • resources/maps/straitofhormuz/manifest.json
  • resources/maps/surrounded/manifest.json
  • resources/maps/tradersdream/manifest.json
  • src/server/MapPlaylist.ts

Walkthrough

This PR adds spawn area definitions for team-based multiplayer game modes across map metadata and game logic. Spawn rectangles are defined in eleven map source files and mirrored into compiled resources, then referenced in map-selection code to override team counts during team games.

Changes

Team game spawn areas

Layer / File(s) Summary
Map generator spawn area definitions
map-generator/assets/maps/aegean/info.json, map-generator/assets/maps/beringsea/info.json, map-generator/assets/maps/beringstrait/info.json, map-generator/assets/maps/bosphorusstraits/info.json, map-generator/assets/maps/conakry/info.json, map-generator/assets/maps/falklandislands/info.json, map-generator/assets/maps/gulfofstlawrence/info.json, map-generator/assets/maps/pluto/info.json, map-generator/assets/maps/straitofgibraltar/info.json, map-generator/assets/maps/straitofhormuz/info.json, map-generator/assets/maps/surrounded/info.json, map-generator/assets/maps/tradersdream/info.json
Spawn area rectangles are added to map metadata for team-based gameplay, defining coordinates and dimensions for 2, 3, or 4 team starting regions per map.
Compiled resource manifest spawn areas
resources/maps/aegean/manifest.json, resources/maps/beringsea/manifest.json, resources/maps/beringstrait/manifest.json, resources/maps/bosphorusstraits/manifest.json, resources/maps/conakry/manifest.json, resources/maps/falklandislands/manifest.json, resources/maps/gulfofstlawrence/manifest.json, resources/maps/pluto/manifest.json, resources/maps/straitofgibraltar/manifest.json, resources/maps/straitofhormuz/manifest.json, resources/maps/surrounded/manifest.json, resources/maps/tradersdream/manifest.json
Spawn area configurations are compiled from map-generator sources into manifest files, preserving spawn geometry and team assignments.
Map-to-team-count assignments
src/server/MapPlaylist.ts
Entries are added to SPECIAL_TEAM_MAPS to reference the new spawn-area-enabled maps, allowing team-count override logic to force specific player counts during team games.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openfrontio/OpenFrontIO#3970: Adds spawn rectangles to additional map spawn configurations, aligned with this PR's team-based spawn-area pattern.

Suggested reviewers

  • evanpelle
  • FloPinguin

🗺️ Spawn zones take shape,
Teams find their starting ground—
Battles may now bloom. 🎮

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding team spawn zones to multiple maps and their integration into the team game system.
Description check ✅ Passed The description is well-related to the changeset, listing all affected maps, their team configurations, rationale, and including screenshots demonstrating the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evanpelle evanpelle added this to the v32 milestone May 28, 2026
Copy link
Copy Markdown
Collaborator

@evanpelle evanpelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management May 28, 2026
@evanpelle evanpelle merged commit b043dc6 into openfrontio:main May 28, 2026
11 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management May 28, 2026
@RickD004 RickD004 deleted the team-maps branch May 29, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants