Skip to content

[Sync] the foveation branch's test fix into develop (e7118fa8: the render test setup resets the immersion style) #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miogds merged 2 commits into from
Oct 16, 2026
Merged

[Sync] the foveation branch's test fix into develop (e7118fa8: the render test setup resets the immersion style) #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7118fa
[Patch] The render test setup resets the immersion style, which the g…
Oct 16, 2026
7ff38ac
Merge feature/xr_headset_rendering at e7118fa8 (untoldengine/UntoldEn…
Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Tests/UntoldEngineRenderTests/BaseRenderSetup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ class BaseRenderSetup: XCTestCase {
applyIBL = false
antiAliasingMode = .fxaa
renderDebugViewMode = .lit
// A test that tries the other immersion modes leaves renderInfo.immersionStyle at the
// last one, and the renderer created here keeps it: every later test would draw that
// mode's graph. The temporal rate-map test showed it, behind RenderGraphBuilderTest.
renderInfo.immersionStyle = .none
currentGlobalTime = 0.0
// Engine defaults (RuntimeGlobalsStore's cameraDefaultFOV/cameraNearPlane/cameraFarPlane
// initial values). A scene-authored asset load (e.g. loadSceneAuthored) overwrites these
Expand Down
2 changes: 2 additions & 0 deletions Tests/UntoldEngineRenderTests/RenderGraphBuilderTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,11 +1683,13 @@ final class RenderGraphBuilderTest: BaseRenderSetup {

func testSupportedRenderExtensionStagesResolveAcrossImmersionModes() throws {
let immersionModes: [UntoldImmersionMode] = [.none, .mixed, .full, .ar]
let savedImmersionStyle = renderInfo.immersionStyle
bypassPostProcessing = true
antiAliasingMode = .none
defer {
bypassPostProcessing = false
antiAliasingMode = .fxaa
renderInfo.immersionStyle = savedImmersionStyle
}

for (modeIndex, immersionMode) in immersionModes.enumerated() {
Expand Down
Loading