Repository navigation
[Sync] the foveation branch's test fix into develop (e7118fa8: the render test setup resets the immersion style) - #79
Merged
Conversation
added 2 commits
October 16, 2026 07:57
…raph builder's immersion-mode case left at AR RenderGraphBuilderTest's testSupportedRenderExtensionStagesResolveAcrossImmersionModes tries .none, .mixed, .full and .ar in turn and left renderInfo.immersionStyle at the last one. Nothing reset it: resetGlobalEngineState did not touch it and the renderer created for the next test keeps it, so every later test in the same process drew the AR base pass. In a serial run the temporal rate-map test failed behind that class (lit pixels lost to a history drawn through the other map); CI never saw it because it runs each render test method in its own process. The base setup now resets the style to .none with the other per-test globals, and the case restores what it found.
…e render test setup resets the immersion style a graph builder case left at AR
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the one commit of untoldengine#1359's branch that
developstill lacks after #78, which merged before this commit reached its branch.e7118fa8, test files only:RenderGraphBuilderTest.testSupportedRenderExtensionStagesResolveAcrossImmersionModesloops the immersion modes and leftrenderInfo.immersionStyleat.ar, and nothing reset it, so every later render test in the same process drew the AR graph; behind that class the temporal rate-map test failed in serial runs.BaseRenderSetupnow resets the style with the other per-test globals, and the case restores what it found. CI never saw the failure because the render tests run one process per method there.Merged clean; no engine code changes. After this,
developholds the whole foveation branch.