Skip to content

Show the full submission ID on run detail #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Naveen Chatlapalli (1aifanatic) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show the full submission ID on run detail #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/portal/src/components/ShortId.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ export const CustomLength: Story = {
},
};

export const FullSubmissionId: Story = {
args: { length: FULL_ID.length, label: "submission ID" },
play: async ({ canvas }) => {
await expect(canvas.getByText(FULL_ID)).toBeVisible();
},
};

export const HoverRevealsFullIdAndCopy: Story = {
play: async ({ canvas }) => {
await userEvent.hover(canvas.getByText("abcdef12"));
Expand Down
5 changes: 5 additions & 0 deletions apps/portal/src/components/ShortId.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ describe("ShortId trigger", () => {
render(<ShortId id={FULL_ID} length={4} />);
expect(screen.getByText("abcd")).toBeTruthy();
});

it("shows the full submission ID on a detail page", () => {
render(<ShortId id={FULL_ID} length={FULL_ID.length} label="submission ID" />);
expect(screen.getByText(FULL_ID)).toBeTruthy();
});
});

describe("ShortId hover + copy", () => {
Expand Down
7 changes: 7 additions & 0 deletions apps/portal/src/pages/RunDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { ReportThumbnail } from "@/components/ReportThumbnail";
import { CriteriaBadge } from "@/components/CriteriaBadge";
import { TaskPromptBadge } from "@/components/TaskPromptBadge";
import { AgentBadge } from "@/components/AgentBadge";
import { ShortId } from "@/components/ShortId";
import { SkillRevisionLinks } from "@/components/SkillRevisionLinks";
import { AlertTriangle, ArrowLeft, Copy, Check, Sparkles, CheckCircle2, XCircle, MinusCircle, FileText, Plus, Download, Loader2, Archive, Video, LayoutGrid, List, Puzzle, RotateCcw, ChevronDown, Clock, Pause, Play, ArrowUpDown, X, Boxes } from "lucide-react";
import { formatDate, formatId, formatDuration, cn } from "@/lib/utils";
Expand Down Expand Up @@ -710,6 +711,12 @@ export function RunDetail() {
/>
)}
<MetaItem label="Created" value={formatDate(run.createdAt)} />
{run.submissionId && (
<MetaItem
label="Submission ID"
value={<ShortId id={run.submissionId} length={run.submissionId.length} label="submission ID" className="break-all text-sm" />}
/>
)}
{run.maxIterations && <MetaItem label="Max iterations" value={run.maxIterations} />}
{(() => {
const totalDuration = activeRun?.turns?.reduce((sum, t) => sum + (t.durationMs ?? 0), 0);
Expand Down
3 changes: 3 additions & 0 deletions docs/architecture/app-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,9 @@ A sibling affordance, `components/ShortId.tsx`, applies the same hoverable-toolt
(`formatId`), and on hover the tooltip reveals the full ID plus a copy-to-clipboard button. The
trigger stays an inline `<span>` (not a link) so the row click still navigates to the run; the
copy button calls `e.stopPropagation()` so copying never triggers row navigation.
Run detail shows the complete submission ID in its metadata when available,
using the same component for an explicit copy action; older runs without a
submission ID omit the field.

## Criteria System

Expand Down