chore(server): simplify action helper signatures - #42904
Dmitry Gozman (dgozman) wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0e8f535 to
d63c53c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Introduce SelectorTarget { selector, strict, scope } and use it in
frame, element handle and frame selectors methods instead of passing
selector, strict and scope separately. StrictOptions is gone.
- Introduce PointerAction descriptor for _retryPointerAction and
_performPointerAction, separating what the action decides from what
the user passed.
- _retryWithProgressIfNotConnected takes explicit retry options instead
of spreading the whole action options.
- Dispatchers pass params as the SelectorTarget.
d63c53c to
586dec2
Compare
Test results for "MCP"1 failed 8763 passed, 1480 skipped Merge workflow run. |
Test results for "tests 1"1 failed 4 flaky52291 passed, 1243 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures on this PR. 🟢 Both failures are pre-existing flakes / infraNeither failing test runs through the selector or pointer-action code this PR refactors, and both have failed before on SHAs this PR can't be responsible for. DetailsThe PR only touches server-side action plumbing ( Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
|
Hi, I'm the Playwright bot and I took a first look at the CI failure. 🟢 The one failure looks like pre-existing infra noise, not this PR
DetailsThere was one real failure. The 4 flaky tests were rescued on retry and aren't counted. Pre-existing flake / infra
A caveat: the DB refresh ( Triaged by the Playwright bot - agent run |
Summary
SelectorTarget { selector, strict, scope }and use it across frame, element handle and frame selectors methods instead of passingselector,strictandscopeseparately.StrictOptionsis gone.PointerActiondescriptor for_retryPointerActionand_performPointerAction, separating what the action decides from what the user passed._retryWithProgressIfNotConnectedtakes explicit retry options instead of spreading the whole action options.paramsas theSelectorTarget.