Skip to content

feat(firefox): roll to r1552 - #42942

Open
microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-firefox/1552
Open

microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-firefox/1552

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/83e9965ae0195faec599765937c4e0f1cd69177b. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52300 passed, 1243 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/http.spec.ts:624 › should close session when heartbeat ping is not answered @mcp-windows-latest-chrome
❌ [chromium] › mcp/webmcp-dynamic.spec.ts:189 › a tool registered in an iframe can be called after the page is reloaded @mcp-macos-latest-chromium
❌ [firefox] › mcp/cli-core.spec.ts:57 › click link @mcp-windows-latest-firefox

8761 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟡 Two failures are known flakes; one is very likely unrelated but I couldn't prove it

This PR only touches Firefox (Juggler PageAgent.js keydown handling on macOS plus the r1552 roll). None of the three MCP failures looks caused by it, but the Chrome heartbeat test has no failure history I could point to.

Details

Overall: the diff changes Firefox key input on macOS (Services.appinfo.OS === 'Darwin') and bumps the Firefox revision. Two of the failures run on Chromium/Chrome, which never load Juggler. The Firefox failure is on Windows, where the new code path is skipped. The tests 1 report shows only flaky tests, no failures.

Pre-existing flake / infra

Uncertain

  • [chrome] › mcp/http.spec.ts:624 › should close session when heartbeat ping is not answered (mcp-windows-latest-chrome): 0 failures in 737 chrome runs in the DB. The only related signal is that retries rescued the same test once each on firefox and webkit, which suggests it's timing-sensitive, but it isn't the same project. It tests the MCP HTTP server's heartbeat on Chrome, which a Firefox-only change can't reach, so I'm confident it's unrelated. To call it a flake, though, I'd need a rerun of the MCP job to come back green, or another chrome failure of this test. (My DB refresh hit a GitHub API 500, so this PR's own runs aren't in the snapshot.)

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

2 failed
❌ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight @firefox-macos-15-large
❌ [android-page] › page/page-set-content.spec.ts:57 › should include shadow roots

33 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/browsercontext-user-agent.spec.ts:110 › should work for navigator.userAgentData and sec-ch-ua headers `@msedge-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-windows-latest`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:36 › should be able to click across browser contexts `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-device.spec.ts:33 › device › should support clicking `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-events.spec.ts:30 › console event should work with element handles `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-15-large`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1934 › should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:683 › selector generator › should generate noText: name from aria-label `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:152 › screencast › should continue recording main page after popup closes `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/signals.spec.ts:25 › should close the browser when the node process closes `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:163 › should propagate default viewport to the page `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1714 › should highlight locator in iframe while typing `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/playwright-client.spec.ts:26 › should connect from a page and drive the same browser `@tracing-webkit`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames scale `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1934 › should not leak recorders `@webkit-macos-15-large`
⚠️ [android-page] › page/locator-click.spec.ts:20 › should work Radoslav Kirilov (@smoke)
⚠️ [android-page] › page/page-goto.spec.ts:481 › should disable timeout when its set to 0
⚠️ [android-page] › page/page-network-request.spec.ts:28 › should work for main frame navigation request
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes
⚠️ [android-page] › page/selectors-frame.spec.ts:203 › should click in lazy iframe

112505 passed, 4782 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Failures look unrelated to this PR

Hi, I'm the Playwright bot and I took a first look at the CI failures. Both failing tests also fail on main and on unrelated PRs, so this Firefox roll looks clear.

Details

This PR rolls Firefox to r1552 and changes PageAgent.js to suppress text input for Option+single-character keydowns with empty text on macOS. Neither failure goes through that code path, and both already fail without this PR.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants