chore(server): clean up action option types - #42902
Merged
Dmitry Gozman (dgozman) merged 1 commit intoSep 25, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
Sep 24, 2026
- Remove unused QueryOnSelectorOptions, MouseMultiClickOptions, VideoOptions and EmulatedSize. - Move scroll to PointerActionWaitOptions, only pointer actions read it. - Add steps to MouseClickOptions and valueOrLabel to SelectOption, both are already sent by the protocol. - Type Frame.drop options as what FrameDropParams actually provides.
Dmitry Gozman (dgozman)
force-pushed
the
chore-server-action-types
branch
from
September 25, 2026 09:25
40e1358 to
4adc8a8
Compare
Contributor
Test results for "tests 1"3 flaky52281 passed, 1255 skipped Merge workflow run. |
Contributor
Test results for "MCP"8751 passed, 1480 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryOnSelectorOptions,MouseMultiClickOptions,VideoOptionsandEmulatedSize.scrolltoPointerActionWaitOptions, since only pointer actions read it.stepstoMouseClickOptionsandvalueOrLabeltoSelectOption, both already sent by the protocol.Frame.dropoptions as whatFrameDropParamsactually provides.