Repository navigation
feat(react-positioning): replace Floating UI with custom positioning engine (exploration) #36870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Dmytro Kirpa (dmytrokirpa)
wants to merge
20
commits into
microsoft:master
Choose a base branch
from
dmytrokirpa:claude/exciting-fermi-h0j6uv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,232
−1,731
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f70229d
feat(react-storybook-addon): add shared SB preview styles
dmytrokirpa 0c8340e
change
dmytrokirpa 98cf730
Merge branch 'microsoft:master' into master
dmytrokirpa 545f61e
Merge branch 'microsoft:master' into master
dmytrokirpa a1da3c7
Merge branch 'microsoft:master' into master
dmytrokirpa 3f359d5
Merge branch 'microsoft:master' into master
dmytrokirpa 8cc280d
Merge branch 'microsoft:master' into master
dmytrokirpa 63cad2a
Merge branch 'microsoft:master' into master
dmytrokirpa a92dad5
feat(react-positioning): replace Floating UI with a CSS-anchor-positi…
claude b585d08
fix(react-positioning): use the strategy option when it is set
claude 9cbd844
Merge branch 'master' into claude/exciting-fermi-h0j6uv
dmytrokirpa 2951aad
fix: resolve positioning migration CI regressions
dmytrokirpa 5142605
Merge remote-tracking branch 'origin/master' into claude/exciting-fer…
dmytrokirpa 3f97279
test(react-positioning): pin browser geometry and lifecycle contracts
dmytrokirpa 746d3ea
fix(react-positioning): align engine with browser contracts
dmytrokirpa d9b900e
test(react-positioning): compare raster with immutable oracle
dmytrokirpa d1eed64
fix(react-positioning): preserve integration contracts
dmytrokirpa da8d3b2
test(react-positioning): isolate native fractional layout quantization
dmytrokirpa e0124c4
test(react-positioning): retain raster checks for control cases
dmytrokirpa e55abfe
test(react-positioning): hide fixture scrollbars in older Chromium
dmytrokirpa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-charts-1cc101ec-348b-4d7f-9b9f-687b8f694ade.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Avoid creating a virtual popover target when no click position is provided.", | ||
| "packageName": "@fluentui/react-charts", | ||
| "email": "dmytrokirpa@microsoft.com" | ||
| } |
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-headless-components-preview-8a41d7c3-2b5f-4e68-a0d9-6c3f1e9b7a24.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "feat(usePositioning): use CSS anchor positioning by default, and the engine of @fluentui/react-positioning when the browser doesn't support it or an option can't be handled by CSS", | ||
| "packageName": "@fluentui/react-headless-components-preview", | ||
| "email": "kirpadv@gmail.com" | ||
| } |
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-positioning-39add3c6-6961-4f67-8af0-e52dc9fb99d2.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Preserve resolved positioning targets, pinned offsets, oversized popup placement, and fixed-position clipping.", | ||
| "packageName": "@fluentui/react-positioning", | ||
| "email": "dmytrokirpa@microsoft.com" | ||
| } |
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-positioning-3f6c1a52-7d0e-4b9a-9c1e-5a2b8d4e6f10.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "feat: compute positions with a built-in engine that follows the rules of CSS anchor positioning, replacing Floating UI to reduce the bundle size", | ||
| "packageName": "@fluentui/react-positioning", | ||
| "email": "kirpadv@gmail.com" | ||
| } | ||
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-positioning-76925269-6201-44d2-ad51-c66d334c5418.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "test(react-positioning): pin portable browser geometry and lifecycle contracts with exact engine output", | ||
| "packageName": "@fluentui/react-positioning", | ||
| "email": "dmytrokirpa@microsoft.com" | ||
| } |
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-positioning-c26c97e4-ca8e-4b26-9ea7-6d72ff5214d4.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Replace the positioning runtime with a standalone parity engine and enforce the 15,000-byte minified budget.", | ||
| "packageName": "@fluentui/react-positioning", | ||
| "email": "dmytrokirpa@microsoft.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
...act-components/react-headless-components-preview/library/bundle-size/TagPicker.fixture.js
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
...mponents/react-headless-components-preview/library/bundle-size/TeachingPopover.fixture.js
This file was deleted.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
...omponents/react-headless-components-preview/library/bundle-size/usePositioning.fixture.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { usePositioning } from '@fluentui/react-headless-components-preview/positioning'; | ||
|
|
||
| console.log(usePositioning); | ||
|
|
||
| export default { | ||
| name: '@fluentui/react-headless-components-preview/positioning: usePositioning', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 13 additions & 2 deletions
15
packages/react-components/react-headless-components-preview/library/src/hooks/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,22 @@ | ||
| export { usePositioning } from './usePositioning'; | ||
| export type { | ||
| Position, | ||
| Alignment, | ||
| AutoSize, | ||
| Offset, | ||
| OffsetFunction, | ||
| OffsetFunctionParam, | ||
| OffsetObject, | ||
| OffsetShorthand, | ||
| Position, | ||
| PositioningBoundary, | ||
| PositioningImperativeRef, | ||
| PositioningProps, | ||
| PositioningRect, | ||
| PositioningReturn, | ||
| PositioningImperativeRef, | ||
| PositioningShorthand, | ||
| PositioningShorthandValue, | ||
| PositioningVirtualElement, | ||
| SetVirtualMouseTarget, | ||
| UsePositioningOptions, | ||
| } from './usePositioning'; | ||
| export { POSITIONS, ALIGNMENTS, getPlacementString, resolvePositioningShorthand } from './usePositioning'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
vr-tests-react-components/Positioning 2 screenshots
vr-tests-react-components/ProgressBar converged 2 screenshots
vr-tests-web-components/Avatar 1 screenshots
vr-tests-web-components/MenuList 2 screenshots
vr-tests/Callout 3 screenshots
vr-tests/Coachmark 1 screenshots
vr-tests/react-charting-LineChart 2 screenshots
vr-tests/react-charting-MultiStackBarChart 4 screenshots
There were 2 duplicate changes discarded. Check the build logs for more information.