Repository navigation
feat(react-positioning): replace Floating UI with custom positioning engine (exploration) - #36870
Draft
Dmytro Kirpa (dmytrokirpa) wants to merge 20 commits into
Draft
Dmytro Kirpa (dmytrokirpa) wants to merge 20 commits into
Dmytro Kirpa (dmytrokirpa) wants to merge 20 commits into
Conversation
Dmytro Kirpa (dmytrokirpa)
force-pushed
the
claude/exciting-fermi-h0j6uv
branch
from
October 12, 2026 17:57
a8dce8a to
69a727b
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 4 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 138 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 732 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 52 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 104 | Changed |
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png | 298 | Changed |
vr-tests-web-components/MenuList 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 498 | Changed |
| vr-tests-web-components/MenuList. - RTL.1st selected.chromium_2.png | 39384 | Changed |
vr-tests/Callout 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2199 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3182 | Changed |
| vr-tests/Callout.Rendering callout attached to a rectangle.default.chromium.png | 1835 | Changed |
vr-tests/Coachmark 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Coachmark.Collapsed.default.chromium.png | 159 | Changed |
vr-tests/react-charting-LineChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Multiple.default.chromium.png | 192 | Changed |
| vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png | 181 | Changed |
vr-tests/react-charting-MultiStackBarChart 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-MultiStackBarChart.Basic_Absolute - RTL.default.chromium.png | 343 | Changed |
| vr-tests/react-charting-MultiStackBarChart.Basic_PartToWhole.default.chromium.png | 359 | Changed |
| vr-tests/react-charting-MultiStackBarChart.Basic_Absolute.default.chromium.png | 359 | Changed |
| vr-tests/react-charting-MultiStackBarChart.Basic_PartToWhole - RTL.default.chromium.png | 343 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Dmytro Kirpa (dmytrokirpa)
force-pushed
the
claude/exciting-fermi-h0j6uv
branch
2 times, most recently
from
October 13, 2026 07:22
ff66b9d to
31c2544
Compare
Dmytro Kirpa (dmytrokirpa)
changed the title
…oning-style engine Port the JavaScript positioning engine into react-positioning and use it in place of @floating-ui/dom to reduce the bundle size: position-area style placements, first-fit fallbacks, margin offsets, containing block detection, boundaries, autoSize, arrow and visibility attributes. Floating UI dependencies are removed. The position manager is slimmer (a capturing scroll listener replaces scroll parent discovery, the direction is read from the containing block) and it can also run when the browser does the positioning with CSS anchor positioning. The headless usePositioning uses CSS anchor positioning by default and the position manager of react-positioning as the fallback, when the browser lacks support or an option can't be handled by CSS (function offsets, boundaries and virtual element targets). autoSize, the arrow and onPositioningEnd are handled in both modes. It writes data-positioning-hidden and data-positioning-escaped, react-positioning keeps the data-popper-* attributes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YQM28hNQxTep97H3Ur6xDm
Dmytro Kirpa (dmytrokirpa)
force-pushed
the
claude/exciting-fermi-h0j6uv
branch
from
October 13, 2026 09:53
0221548 to
a92dad5
Compare
`strategy ?? positionFixed ? 'fixed' : 'absolute'` was parsed as `(strategy ?? positionFixed) ? 'fixed' : 'absolute'`, so any set strategy, including 'absolute', resulted in 'fixed'. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YQM28hNQxTep97H3Ur6xDm
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmytro Kirpa (dmytrokirpa)
changed the title
Dmytro Kirpa (dmytrokirpa)
changed the title
Dmytro Kirpa (dmytrokirpa)
changed the title
This was referenced Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)