Skip to content

fix(react-headless-components-preview): use global focusgroup typing for MenuListState #36608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dmytro Kirpa (dmytrokirpa) wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −16
Open

fix(react-headless-components-preview): use global focusgroup typing for MenuListState #36608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-headless-components-preview-menulist-focusgroup-typing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: use global focusgroup typing for MenuListState instead of a local intersection",
"packageName": "@fluentui/react-headless-components-preview",
"email": "dmytrokirpa@microsoft.com",
"dependentChangeType": "patch"
}
11 changes: 3 additions & 8 deletions ...ages/react-components/react-headless-components-preview/library/etc/menu.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import { MenuItemSwitchState } from '@fluentui/react-menu';
import type { MenuListContextValues } from '@fluentui/react-menu';
import { MenuListProps } from '@fluentui/react-menu';
import { MenuListSlots } from '@fluentui/react-menu';
import type { MenuListState as MenuListState_2 } from '@fluentui/react-menu';
import { MenuListState } from '@fluentui/react-menu';
import { MenuOpenChangeData } from '@fluentui/react-menu';
import { MenuOpenEvent } from '@fluentui/react-menu';
import { MenuPopoverProps } from '@fluentui/react-menu';
Expand Down Expand Up @@ -166,12 +166,7 @@ export { MenuListProps }

export { MenuListSlots }

// @public (undocumented)
export type MenuListState = MenuListState_2 & {
root: {
focusgroup?: string;
};
};
export { MenuListState }

export { MenuOpenChangeData }

Expand Down Expand Up @@ -228,7 +223,7 @@ export { renderMenuItemRadio }
export { renderMenuItemSwitch }

// @public (undocumented)
export const renderMenuList: (state: MenuListState_2, contextValues: MenuListContextValues) => JSXElement;
export const renderMenuList: (state: MenuListState, contextValues: MenuListContextValues) => JSXElement;

// @public (undocumented)
export const renderMenuPopover: (state: MenuPopoverState) => JSXElement;
Expand Down
9 changes: 1 addition & 8 deletions .../react-headless-components-preview/library/src/components/Menu/MenuList/MenuList.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
import type { MenuListState as MenuListBaseState } from '@fluentui/react-menu';

export type {
MenuListState,
MenuListProps,
MenuListSlots,
MenuCheckedValueChangeData,
MenuCheckedValueChangeEvent,
} from '@fluentui/react-menu';

export type MenuListState = MenuListBaseState & {
root: {
focusgroup?: string;
};
};
Loading