fix(react-headless-components-preview): use global focusgroup typing for MenuListState - #36608
Open
Dmytro Kirpa (dmytrokirpa) wants to merge 1 commit into
Conversation
…for MenuListState
MenuListState locally intersected the base state with '{ root: { focusgroup?: string } }'
to type the attribute set in useMenuList. The repo-wide 'typings/focusgroup' augmentation
already adds a strongly typed 'focusgroup' to React's HTMLAttributes, so the local override
was redundant, weaker (plain string), and forced the base type to be re-exported under an
alias in the public API.
Re-export MenuListState directly from '@fluentui/react-menu'.
📊 Bundle size report✅ No changes found |
Dmytro Kirpa (dmytrokirpa)
requested review from
Martin Hochel (Hotell) and
Victor Genaev (mainframev)
August 22, 2026 13:52
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MenuListStatelocally intersected the base state with a hand-rolledfocusgroupdeclaration:This existed only to type the attribute assigned in
useMenuList. But the repo-widetypings/focusgroupaugmentation already addsfocusgroupto React'sHTMLAttributes, so the local override was:rootstringinstead of the constrainedFocusgroupAttributeunion, so invalid values likefocusgroup=\"tree\"wouldn't be caughtMenuListState_2aliasNow
MenuListStateis re-exported directly from@fluentui/react-menu, anduseMenuListrelies on the global typing.Verification
yarn nx run react-headless-components-preview:type-checkpassesetc/menu.api.mdregenerated — the alias and the local intersection are gone