Finish ESM transition, move to composite builds, detangle type refs, and re-enable macos PR pipeline#4124
Merged
Conversation
…tive into user/jasonvmo/esm
…ypes in include tree
Saadnajmi
reviewed
Jun 12, 2026
The Windows E2E launch script was throwing a cryptic 'Cannot find a process with the name ReactApp' when the app crashed during launch, hiding the root cause. - Register WER local dumps BEFORE launching the app (so first-launch crashes are captured) - Wait up to 30s for the app to appear with a top-level window (instead of 10s) - On failure, dump running processes, WER dumps, Application event-log entries since launch, and the packager log, then throw a clear error - Redirect 'yarn start' output to apps/fluent-tester/packager.log and upload it as a CI artifact Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The generated AppxManifest in 5.1.10 was missing the `<PackageDependency Name="Microsoft.WindowsAppRuntime.1.8" .../>` entry, which caused IReactNativeHost::PackageProviders to throw REGDB_E_CLASSNOTREG (0x80040154) at launch (the activatable classes from the Windows App SDK framework package were not visible to the AppContainer process). The unhandled C++ exception terminated ReactApp.exe before any window was created, breaking Windows E2E. react-native-test-app 5.2.3 now correctly injects the WindowsAppRuntime package dependency into the generated AppxManifest, restoring the ability of the packaged app to activate WinAppSDK types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Saadnajmi
reviewed
Jun 12, 2026
Saadnajmi
reviewed
Jun 12, 2026
Saadnajmi
reviewed
Jun 12, 2026
Saadnajmi
reviewed
Jun 12, 2026
Saadnajmi
reviewed
Jun 12, 2026
Saadnajmi
reviewed
Jun 12, 2026
Saadnajmi
reviewed
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This change has a number of things rolled together into one PR as one thing kind of led to another.
Move to ESM
The previous strategy of using module/moduleResolution: "nodenext" doesn't work to esm output on react native because if a module import as an extension (i.e.
import { foo } from "myFile.ts";) this will stop both metro and typescript from finding myFile.android.ts or other module suffixes. As a result:Composite builds
To speed up builds, and avoid race conditions for the lage builds where the file wasn't fully committed before the next tsgo instance tried to pick it up, I turned on project references and building with tsgo -b.
Type defragmentation
The massive parallelism of tsgo highlighted places where we were bringing in multiple versions of @types/react into the same package. The main sources were the icons package bringing in a @types/react-native: 0.68 package and the adapters package including rn, rnw, and rn-macos in the same build, each of which have rn -> react -> react types. Resolution in these cases can be order dependent and is a problem, these were all made more explicit.
Re-enable macos pipelines
This also attempts to enable the macos PR builds again as they were turned off in the recent 81 test app changeover.
Verification