Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ Legends:
- Fixed code samples, such as in the "View code" dialog, titled "Javascript" instead of "JavaScript": common programming languages and their aliases, such as `js`, now show their proper names, which can be overridden via `overrideLocalizedStrings` (`PROGRAMMING_LANGUAGE_*`), in PR [#5896](https://github.com/microsoft/BotFramework-WebChat/pull/5896), by [@OEvgeny](https://github.com/OEvgeny)
- Fixed code not being highlighted when the programming language is not in lowercase, such as `TS`, in PR [#5896](https://github.com/microsoft/BotFramework-WebChat/pull/5896), by [@OEvgeny](https://github.com/OEvgeny)
- Fixed GIFs in animation cards looping with no way to stop them: they now have a pause button, and do not play when the user prefers reduced motion or the card has `autostart: false`; the icons of the Copy and View code buttons are now visible in forced colors, fixes [#5734](https://github.com/microsoft/BotFramework-WebChat/issues/5734), in PR [#5897](https://github.com/microsoft/BotFramework-WebChat/pull/5897), by [@OEvgeny](https://github.com/OEvgeny)
- Fixed the play, mute, and "more options" icons of audio players being invisible in dark high contrast themes, such as "Aquatic" on Windows, fixes [#5710](https://github.com/microsoft/BotFramework-WebChat/issues/5710), in PR [#5906](https://github.com/microsoft/BotFramework-WebChat/pull/5906), by [@OEvgeny](https://github.com/OEvgeny)
- Fixed the "Positive" card action button having less than 4.5:1 color contrast, fixes [#5713](https://github.com/microsoft/BotFramework-WebChat/issues/5713), in PR [#5905](https://github.com/microsoft/BotFramework-WebChat/pull/5905), by [@OEvgeny](https://github.com/OEvgeny)
- Fixed screen readers announcing a single audio, video, or animation in a card as a list item, such as "1 of 1", fixes [#5722](https://github.com/microsoft/BotFramework-WebChat/issues/5722), in PR [#5903](https://github.com/microsoft/BotFramework-WebChat/pull/5903), by [@OEvgeny](https://github.com/OEvgeny)
- Fixed video and animation cards disappearing in production builds when the video URL is relative or invalid, in PR [#5889](https://github.com/microsoft/BotFramework-WebChat/pull/5889), by [@OEvgeny](https://github.com/OEvgeny)
Expand Down
79 changes: 0 additions & 79 deletions __tests__/html2/attachment/audio.forcedColors.dark.html

This file was deleted.

Binary file not shown.
80 changes: 0 additions & 80 deletions __tests__/html2/attachment/video.forcedColors.dark.html

This file was deleted.

Binary file not shown.
10 changes: 1 addition & 9 deletions packages/component/src/Styles/StyleSet/AudioContent.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
import { FORCED_COLORS_SELECTOR } from './Constants';

export default function AudioContent() {
return {
width: '100%',

// Chromium picks the player icons by the color scheme of the element, not by the forced colors palette, so dark palettes (e.g. "Aquatic" on Windows) get dark icons.
// TODO: Remove when Chromium is fixed, https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/media_controls/resources/mediaControls.css.
[FORCED_COLORS_SELECTOR]: {
colorScheme: 'light dark'
}
width: '100%'
};
}
9 changes: 1 addition & 8 deletions packages/component/src/Styles/StyleSet/VideoContent.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
import { StrictStyleOptions } from 'botframework-webchat-api';

import { FORCED_COLORS_SELECTOR } from './Constants';

export default function createVideoContentStyle({ videoHeight }: StrictStyleOptions) {
return {
height: videoHeight,
width: '100%',

// Without a video track (e.g. a voice message), Chromium shows the controls of the audio player, which need the same workaround as `AudioContent`.
[FORCED_COLORS_SELECTOR]: {
colorScheme: 'light dark'
}
width: '100%'
};
}
Loading