Skip to content

Revert forced colors color-scheme on audio and video players - #5925

Merged
Eugene (OEvgeny) merged 2 commits into
mainfrom
OEvgeny/fix-revert-media-color-scheme
Oct 20, 2026
Merged

Eugene (OEvgeny) merged 2 commits into
mainfrom
OEvgeny/fix-revert-media-color-scheme

Conversation

@OEvgeny

Copy link
Copy Markdown
Collaborator

Reverts #5906

Changelog Entry

None: #5906's entry was unreleased and is removed.

Description

In real dark high contrast themes, such as "Aquatic" on Windows 11, the color-scheme: light dark workaround from #5906 hides the play, mute, and "more options" icons of audio players and voice messages on a fresh render, while players without it show them. This PR reverts the workaround, its 2 tests, and its changelog entry.

Design

  • Revert instead of replacing the workaround: on a fresh render, Chromium's default media controls already match the forced colors palette; the remaining issue (icons not updated after switching palettes) is a Chromium bug.
  • The 2 tests are removed, not rewritten: forced colors emulation (DevTools/CDP) does not reach the media control icons, so html2 tests cannot show the real rendering.

Specific Changes

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

In real dark high contrast themes (e.g. "Aquatic" on Windows 11), a fresh
render with `color-scheme: light dark` shows no play, mute and "more
options" icons on audio players and voice messages, while players without
the rule show them. Forced colors emulation (DevTools/CDP) does not reach
the media control icons, so the removed tests only showed the emulated
rendering.

This reverts the style rules, tests and unreleased changelog entry of
commit eb6e765.
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 19, 2026 22:29
Copilot AI balanced review requested due to automatic review settings October 19, 2026 22:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@OEvgeny
Eugene (OEvgeny) enabled auto-merge (squash) October 19, 2026 22:30
@OEvgeny
Eugene (OEvgeny) merged commit 241d83c into main Oct 20, 2026
32 checks passed
@OEvgeny
Eugene (OEvgeny) deleted the OEvgeny/fix-revert-media-color-scheme branch October 20, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants