Repository navigation
Revert forced colors color-scheme on audio and video players - #5925
Merged
Merged
Conversation
In real dark high contrast themes (e.g. "Aquatic" on Windows 11), a fresh render with `color-scheme: light dark` shows no play, mute and "more options" icons on audio players and voice messages, while players without the rule show them. Forced colors emulation (DevTools/CDP) does not reach the media control icons, so the removed tests only showed the emulated rendering. This reverts the style rules, tests and unreleased changelog entry of commit eb6e765.
Eugene (OEvgeny)
marked this pull request as ready for review
October 19, 2026 22:29
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 19, 2026 22:29
Eugene (OEvgeny)
enabled auto-merge (squash)
October 19, 2026 22:30
William Wong (compulim)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
None: #5906's entry was unreleased and is removed.
Description
In real dark high contrast themes, such as "Aquatic" on Windows 11, the
color-scheme: light darkworkaround from #5906 hides the play, mute, and "more options" icons of audio players and voice messages on a fresh render, while players without it show them. This PR reverts the workaround, its 2 tests, and its changelog entry.Design
Specific Changes
AudioContent.ts,VideoContent.ts: removed the forced colorscolor-schemeruleattachment/audio.forcedColors.dark.htmlandattachment/video.forcedColors.dark.htmlwith their snapshotsCHANGELOG.md: removed Show audio player icons in dark high contrast themes #5906's entryCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed