Repository navigation
Separate link reference markers from the previous word for screen readers - #5923
Draft
Eugene (OEvgeny) wants to merge 3 commits into
Draft
Eugene (OEvgeny) wants to merge 3 commits into
Eugene (OEvgeny) wants to merge 3 commits into
Conversation
| ); | ||
|
|
||
| // THEN: the live region announces the same text on arrival. | ||
| await waitFor(() => |
Collaborator
Author
There was a problem hiding this comment.
TODO: visualize the region via CSS override and take snapshot
added 2 commits
October 19, 2026 15:42
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-citation-marker-name
branch
from
October 19, 2026 22:43
013fd8f to
3058bc3
Compare
2 of 11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
settings[1], in PR #5923, by @OEvgenyDescription
The text alternative of a Markdown message (message summary on arrow keys and live region on arrival) only joined text nodes, so a link or citation button written right after a word, such as
[1], became part of that word. A space is now added before a link or button when the text before it does not end with whitespace, so it reads "settings 1.".Design
Specific Changes
packages/component/src/Utils/activityAltText.ts: add a space before<a>and<button>when glued to the previous textaccessibility/accessibleName.linkReference.html: new test, asserts the message accessible name and the live region text read "settings 1."; snapshot 1 shows the live region "Override the proxy settings 1." above the transcript "settings[1]."I have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed