Repository navigation
Say "Click to interact." for messages with links - #5927
Draft
Eugene (OEvgeny) wants to merge 3 commits into
Draft
Eugene (OEvgeny) wants to merge 3 commits into
Eugene (OEvgeny) wants to merge 3 commits into
Conversation
added 2 commits
October 19, 2026 16:29
InteractiveType.LINK is 0, so the truthiness check treated messages with links as not interactive.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
InteractiveType.LINKis the first enum member (0), so the truthiness check for the footnote treated messages with links as not interactive: they were named "… One or more links in the message." without "Click to interact.". The interactive type is now a string union ('link' | 'widget'), so every type is truthy.Design
accessibleName.linkReference.html: whichever merges second appends " Click to interact." there.Specific Changes
useActivityAccessibleName.ts:type InteractiveType = 'link' | 'widget'instead ofenum InteractiveType { LINK, WIDGET }accessibility/accessibleName.link.html: a plain message has no footnote, a message with a link ends with "One or more links in the message. Click to interact." (state only, no snapshots)CHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed