Repository navigation
Keep the carousel still when arrow keys are pressed on a button or link inside a card - #5917
Merged
Merged
Conversation
Eugene (OEvgeny)
marked this pull request as ready for review
October 19, 2026 19:26
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 19, 2026 19:26
2 of 11 tasks
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-carousel-button-arrow-scroll
branch
from
October 20, 2026 02:23
b29c90d to
502e311
Compare
added 4 commits
October 20, 2026 11:26
On a control without its own arrow keys (button, link, checkbox), the browser scrolled the carousel by 40 px and react-film centered the card again about 500 ms later; a held key scrolled the focused button out of view. Text inputs, radio buttons, selects, dates, and media keep their arrow keys.
… card Adaptive Cards render a selectAction with Action.OpenUrl on a Container, Column, or Image as <div tabindex="0" role="link">; add [role="link"] to the controls whose LEFT/RIGHT do nothing inside a card, and test it.
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-carousel-button-arrow-scroll
branch
from
October 20, 2026 18:26
502e311 to
36123c1
Compare
William Wong (compulim)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
On a button inside a card, the browser scrolled the carousel by 40 pixels and react-film centered the card again half a second later; holding the key scrolled the focused button out of view. LEFT/RIGHT now do nothing on buttons, links, and checkboxes inside a card.
Design
role="button",role="link"), not a deny-list of inputs, so text inputs, radio buttons, selects, dates, media, and focusable scroll regions keep their native arrow keys.Specific Changes
CarouselFilmStrip.js: prevent the default of LEFT/RIGHT on those controls inside a cardcarousel/navigation.arrowKeys.button.html: new test, snapshots 3–5 and 8–9, a hero card button and an Adaptive Card container with Action.OpenUrl (role="link") keep focus and the carousel does not scrollcarousel/navigation.arrowKeys.formControls.html: RIGHT on buttons no longer waits for a scroll; snapshots 4–7: TAB centers the hero card (Scroll carousel cards into view when focused with Tab #5926), then LEFT/RIGHT on its button keep it stillCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed