Repository navigation
Scroll carousel cards into view when focused with Tab - #5926
Open
Eugene (OEvgeny) wants to merge 2 commits into
Open
Eugene (OEvgeny) wants to merge 2 commits into
Eugene (OEvgeny) wants to merge 2 commits into
Conversation
added 2 commits
October 19, 2026 16:05
When the keyboard moves the focus into a carousel card from outside of it (TAB or SHIFT-TAB), center the card with react-film, as LEFT/RIGHT do, instead of leaving it partially visible. Focus by pointer is not :focus-visible and does not scroll.
Eugene (OEvgeny)
marked this pull request as ready for review
October 20, 2026 00:26
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 20, 2026 00:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
A card focused with TAB could stay partially out of view, unlike with LEFT/RIGHT (#5904). Now, when keyboard focus enters a card from outside of it, react-film centers the card, as the arrow keys do.
Design
:focus-visible: clicking a card or a button does not scroll; clicking a text input (always:focus-visible) does.formControls.submitButton.htmlsnapshot 6) and Keep the carousel still when arrow keys are pressed on a button or link inside a card #5917 (formControls.htmlhero card button steps): whichever merges second updates them.Specific Changes
CarouselFilmStrip.js:onFocuson the card list centers the card that the focus enters with the keyboardcarousel/navigation.tab.scrollIntoView.html: snapshots 1–4, card 1 → its button → TAB centers card 2 → SHIFT + TAB scrolls back to card 1carousel/navigation.tab.scrollIntoView.pointer.html: snapshot 1, clicking card 2 focuses it without scrollingcarousel/navigation.arrowKeys.formControls.html: TAB into the hero card now scrolls it into viewCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed