Skip to content

Name and pre-fill Adaptive Card inputs in the live region as in the card - #5913

Open
Eugene (OEvgeny) wants to merge 7 commits into
mainfrom
OEvgeny/fix-liveregion-card-inputs
Open

Eugene (OEvgeny) wants to merge 7 commits into
mainfrom
OEvgeny/fix-liveregion-card-inputs

Conversation

@OEvgeny

@OEvgeny Eugene (OEvgeny) commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Adaptive Card inputs in the live region copy of new messages have no name and no value.

Changelog Entry

Fixed

  • Fixed screen readers announcing new Adaptive Card inputs without their labels and values, in PR #5913, by @OEvgeny

Description

The live region copy of an Adaptive Card labeled text, number, date, and time inputs with their title, which they do not have, so they were announced without a name, and it dropped pre-filled values. The copy now names them as the transcript does (aria-label from label, otherwise their placeholder, so labels are read once) and pre-fills their values.

Design

  • Kept the native controls (out of the tab order, as live region suggested actions are), so roles are still announced; inert would remove the whole copy from the accessibility tree.

Specific Changes

  • AdaptiveCardAttachment.js (screen reader renderer): text, number, date, and time inputs get aria-label from label instead of a <label> with title text

  • Added accessibility/liveRegion/attachment/adaptiveCard.inputLabel.html: inputs are named, labels are not repeated as text, inputs are out of the tab order; snapshot 1 shows the copy

  • AdaptiveCardAttachment.js: inputs get defaultValue, toggles are checked from defaultValue (was always unchecked); adaptiveCard.inputValue.html snapshot 1 shows the values as in the card

  • I have added tests and executed them locally

  • I have added .changelog/<PR#>-<slug>.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny Eugene (OEvgeny) changed the title Name Adaptive Card inputs in the live region by their label or placeholder Name and pre-fill Adaptive Card inputs in the live region as in the card Oct 19, 2026
@OEvgeny

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-10-19 105628

@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 19, 2026 19:19
Copilot AI balanced review requested due to automatic review settings October 19, 2026 19:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@OEvgeny

Copy link
Copy Markdown
Collaborator Author
image

@OEvgeny
Eugene (OEvgeny) force-pushed the OEvgeny/fix-liveregion-card-inputs branch from a1dca50 to 1e4429f Compare October 19, 2026 22:43
@OEvgeny
Eugene (OEvgeny) force-pushed the OEvgeny/fix-liveregion-card-inputs branch 2 times, most recently from b1dabd0 to 060cd48 Compare October 20, 2026 20:24
Eugene Olonov added 4 commits October 20, 2026 13:55
…older

The screen reader copy read the nonexistent `title` of text, number, date, and time inputs, so they had no accessible name while the copy was in the live region.
The live region copy rendered each label as text next to the input it names, so screen readers read the label twice. Name text, number, date, and time inputs with aria-label instead; inputs without a label stay named by their placeholder.
@OEvgeny
Eugene (OEvgeny) force-pushed the OEvgeny/fix-liveregion-card-inputs branch from 060cd48 to 788ddc3 Compare October 20, 2026 20:57
# Conflicts:
#	packages/bundle/src/adaptiveCards/AttachmentForScreenReader/AdaptiveCardAttachment.js
@OEvgeny

Copy link
Copy Markdown
Collaborator Author

Resolve and push

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants