Repository navigation
Name and pre-fill Adaptive Card inputs in the live region as in the card - #5913
Open
Eugene (OEvgeny) wants to merge 7 commits into
Open
Eugene (OEvgeny) wants to merge 7 commits into
Eugene (OEvgeny) wants to merge 7 commits into
Conversation
Collaborator
Author
Eugene (OEvgeny)
marked this pull request as ready for review
October 19, 2026 19:19
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 19, 2026 19:19
2 of 11 tasks
Collaborator
Author
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-liveregion-card-inputs
branch
from
October 19, 2026 22:43
a1dca50 to
1e4429f
Compare
2 of 11 tasks
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-liveregion-card-inputs
branch
2 times, most recently
from
October 20, 2026 20:24
b1dabd0 to
060cd48
Compare
added 4 commits
October 20, 2026 13:55
…older The screen reader copy read the nonexistent `title` of text, number, date, and time inputs, so they had no accessible name while the copy was in the live region.
The live region copy rendered each label as text next to the input it names, so screen readers read the label twice. Name text, number, date, and time inputs with aria-label instead; inputs without a label stay named by their placeholder.
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-liveregion-card-inputs
branch
from
October 20, 2026 20:57
060cd48 to
788ddc3
Compare
William Wong (compulim)
previously approved these changes
Oct 20, 2026
# Conflicts: # packages/bundle/src/adaptiveCards/AttachmentForScreenReader/AdaptiveCardAttachment.js
Collaborator
Author
|
Resolve and push |
Eugene (OEvgeny)
dismissed
William Wong (compulim)’s stale review
via
October 21, 2026 04:01
b848089
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changelog Entry
Fixed
Description
The live region copy of an Adaptive Card labeled text, number, date, and time inputs with their
title, which they do not have, so they were announced without a name, and it dropped pre-filled values. The copy now names them as the transcript does (aria-labelfromlabel, otherwise theirplaceholder, so labels are read once) and pre-fills their values.Design
inertwould remove the whole copy from the accessibility tree.Specific Changes
AdaptiveCardAttachment.js(screen reader renderer): text, number, date, and time inputs getaria-labelfromlabelinstead of a<label>withtitletextAdded
accessibility/liveRegion/attachment/adaptiveCard.inputLabel.html: inputs are named, labels are not repeated as text, inputs are out of the tab order; snapshot 1 shows the copyAdaptiveCardAttachment.js: inputs getdefaultValue, toggles are checked fromdefaultValue(was always unchecked);adaptiveCard.inputValue.htmlsnapshot 1 shows the values as in the cardI have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed