Repository navigation
Read Adaptive Card text in the live region when the card has no speak - #5922
Open
Eugene (OEvgeny) wants to merge 3 commits into
Open
Eugene (OEvgeny) wants to merge 3 commits into
Eugene (OEvgeny) wants to merge 3 commits into
Conversation
added 3 commits
October 19, 2026 13:37
Without `speak`, the live region copy of an Adaptive Card was just "A card:". It now reads the card's TextBlock, RichTextBlock, and FactSet text in document order. `speak` still takes precedence when present.
…egion Skip elements with isVisible: false (and their subtrees) when collecting the card text, and do not descend into actions.
Eugene (OEvgeny)
marked this pull request as ready for review
October 20, 2026 00:30
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 20, 2026 00:30
Collaborator
Author
|
Might be too naive, but maybe worth it as a start, William Wong (@compulim) ? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
speakas just "A card", they now read the card text, in PR #5922, by @OEvgenyDescription
The live region copy of an Adaptive Card only used
speak, so cards without it (most bots) were announced as "A card:" with none of their text. Withoutspeak, it now reads the visible card text in document order (hidden elements, including hidden inputs, and collapsedAction.ShowCardcards are skipped);speakstill wins when present.Design
{{DATE()}}are not processed, like hero card text.AdaptiveCardAttachment.js(label vs. inputs); the two merge cleanly.Specific Changes
AdaptiveCardAttachment.js: card label falls back to the card text whenspeakis missing;walkAllItemsskips hidden elementsadaptiveCard.text.html: snapshot 1, the live region reads "A card: Seattle Sunny, 21°C Bot avatar Humidity: 40% Wind: 8 km/h Updated 5 minutes ago"adaptiveCard.hiddenText.html: snapshot 1, hidden text, a hidden input and the collapsed show-card text are not read ("A card: Seattle")adaptiveCard.speakOverText.html: snapshot 1, a card withspeakis still read byspeakonlyCHANGELOG.md: entryI have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed