Skip to content

fix(web): show sub-work items on the parent in local #9804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RealBhupesh wants to merge 1 commit into
base: preview
Choose a base branch
from
+22 −10
Open

fix(web): show sub-work items on the parent in local #9804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions apps/web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,28 @@ export const SubIssuesCollapsibleContent = observer(function SubIssuesCollapsibl
);

const handleFetchSubIssues = useCallback(async () => {
const currentSubIssueHelpers = subIssueHelpersByIssueId(`${parentIssueId}_root`);
if (!currentSubIssueHelpers.issue_visibility.includes(parentIssueId)) {
try {
setSubIssueHelpers(`${parentIssueId}_root`, "preview_loader", parentIssueId);
await subIssueOperations.fetchSubIssues(workspaceSlug, projectId, parentIssueId);
setSubIssueHelpers(`${parentIssueId}_root`, "issue_visibility", parentIssueId);
} catch (error) {
console.error("Error fetching sub-work items:", error);
} finally {
setSubIssueHelpers(`${parentIssueId}_root`, "preview_loader", "");
const helperId = `${parentIssueId}_root`;
const currentSubIssueHelpers = subIssueHelpersByIssueId(helperId);
// setSubIssueHelpers toggles membership. Skip if visible or a fetch is already in flight
// so React Strict Mode's double effect does not add then remove visibility.
if (
currentSubIssueHelpers.issue_visibility.includes(parentIssueId) ||
currentSubIssueHelpers.preview_loader.includes(parentIssueId)
) {
return;
}

try {
setSubIssueHelpers(helperId, "preview_loader", parentIssueId);
await subIssueOperations.fetchSubIssues(workspaceSlug, projectId, parentIssueId);
if (!subIssueHelpersByIssueId(helperId).issue_visibility.includes(parentIssueId)) {
setSubIssueHelpers(helperId, "issue_visibility", parentIssueId);
}
} catch (error) {
console.error("Error fetching sub-work items:", error);
} finally {
if (subIssueHelpersByIssueId(helperId).preview_loader.includes(parentIssueId)) {
setSubIssueHelpers(helperId, "preview_loader", parentIssueId);
}
}
}, [parentIssueId, projectId, setSubIssueHelpers, subIssueHelpersByIssueId, subIssueOperations, workspaceSlug]);
Expand Down