fix(web): show sub-work items on the parent in local - #9804
Conversation
setSubIssueHelpers toggles membership, and React Strict Mode runs the mount fetch twice, so the second completion removed issue_visibility and hid the list. Skip in-flight fetches and only add visibility once. Co-authored-by: Cursor <cursoragent@cursor.com>
◈ PR Lens
Architecture 1 component touched across 3 lanes. Data flow
Drill down
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe sub-issue fetch handler now prevents duplicate fetches, avoids redundant visibility updates, and preserves loader state during cleanup. ChangesSub-issue fetch handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This change restores visibility of sub-items under parent issues while avoiding duplicate fetches and unnecessary loader or visibility updates. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Sub-work items added to a parent did not appear under the collapsible in local. `setSubIssueHelpers` toggles array membership, and React Strict Mode runs the mount fetch twice. The second completion removed `issue_visibility`, so the list stayed empty even though the fetch succeeded.
This skips a second in-flight fetch, only adds visibility when it is missing, and clears the preview loader with the same toggle (empty string was a no-op).
Type of Change
Screenshots and Media (if applicable)
N/A — full local Plane stack was not run. The reporter already isolated the `issue_visibility` gate in `sub-issues/content.tsx`.
Test Scenarios
References
Fixes #9612
Made with Cursor
Summary by CodeRabbit