fix(website): Fix applying file mappings for compressed metadata files - #7119
Draft
tombch wants to merge 4 commits into
Draft
fix(website): Fix applying file mappings for compressed metadata files#7119tombch wants to merge 4 commits into
tombch wants to merge 4 commits into
Conversation
| filesColumnCell(Object.keys(FILES_SINGLE), ID_1), | ||
| ], | ||
| ], | ||
| isGzipped, |
Contributor
There was a problem hiding this comment.
You could potentially parametrize this test over gzipped? (If it's a 1-1 of an existing non-gzipped test case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #7120
Summary
applyFileMappingsto fail at writing to the file (as it cannot see the metadata headers) and the submission unable to continue.applyFileMappingsto later read correctly.Notes
FormOrUploadWrapper, and further processing occur in theDataUploadForm'shandleSubmitfunction, which silently depends on actions like making sure the file is decompressed in the files factory. So I'd be happy to expand on this if we don't think this is a sufficient fix for now.Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable