Skip to content

fix(phonic, baseten): register plugin loggers so debug/info logs show up #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinalenguyen merged 1 commit into from
Oct 21, 2026
Merged

fix(phonic, baseten): register plugin loggers so debug/info logs show up #8007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion livekit-plugins/livekit-plugins-baseten/livekit/plugins/baseten/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

class BasetenPlugin(Plugin):
def __init__(self) -> None:
super().__init__(__name__, __version__, __package__)
super().__init__(__name__, __version__, __package__, logger)


Plugin.register_plugin(BasetenPlugin())
Expand Down
12 changes: 12 additions & 0 deletions livekit-plugins/livekit-plugins-phonic/livekit/plugins/phonic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,15 @@
from .version import __version__

__all__ = ["__version__", "realtime"]

from livekit.agents import Plugin

from .log import logger


class PhonicPlugin(Plugin):
def __init__(self) -> None:
super().__init__(__name__, __version__, __package__, logger)
Comment on lines +11 to +13

@devin-ai-integration devin-ai-integration Bot Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Phonic plugin registration lacks required documentation

Adding PhonicPlugin without documenting its class or initializer violates the repository's documentation requirement for new classes and methods.

Suggested change
class PhonicPlugin(Plugin):
def __init__(self) -> None:
super().__init__(__name__, __version__, __package__, logger)
class PhonicPlugin(Plugin):
"""Register the Phonic provider with the LiveKit Agents plugin system."""
def __init__(self) -> None:
"""Initialize the plugin metadata and logger."""
super().__init__(__name__, __version__, __package__, logger)

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.



Plugin.register_plugin(PhonicPlugin())
Comment on lines +13 to +16

@devin-ai-integration devin-ai-integration Bot Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟥 Phonic conversation text reaches unredacted stdout

With CLI logging at INFO or DEBUG, PhonicPlugin enables user text or system prompts to reach stdout. The CLI formatters print lk.pii.* fields without redaction, even when project redaction is enabled.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Loading