Repository navigation
fix(phonic, baseten): register plugin loggers so debug/info logs show up - #8007
Merged
tinalenguyen merged 1 commit intoOct 21, 2026
Merged
Conversation
phonic never registered itself and baseten registered without its logger, so the CLI never set a level on either logger and both stayed at the inherited WARNING.
Comment on lines
+11
to
+13
| class PhonicPlugin(Plugin): | ||
| def __init__(self) -> None: | ||
| super().__init__(__name__, __version__, __package__, logger) |
Contributor
There was a problem hiding this comment.
π‘ Phonic plugin registration lacks required documentation
Adding PhonicPlugin without documenting its class or initializer violates the repository's documentation requirement for new classes and methods.
Suggested change
| class PhonicPlugin(Plugin): | |
| def __init__(self) -> None: | |
| super().__init__(__name__, __version__, __package__, logger) | |
| class PhonicPlugin(Plugin): | |
| """Register the Phonic provider with the LiveKit Agents plugin system.""" | |
| def __init__(self) -> None: | |
| """Initialize the plugin metadata and logger.""" | |
| super().__init__(__name__, __version__, __package__, logger) |
Was this helpful? React with π or π to provide feedback.
Comment on lines
+13
to
+16
| super().__init__(__name__, __version__, __package__, logger) | ||
|
|
||
|
|
||
| Plugin.register_plugin(PhonicPlugin()) |
Contributor
There was a problem hiding this comment.
π₯ Phonic conversation text reaches unredacted stdout
With CLI logging at INFO or DEBUG, PhonicPlugin enables user text or system prompts to reach stdout. The CLI formatters print lk.pii.* fields without redaction, even when project redaction is enabled.
Was this helpful? React with π or π to provide feedback.
tinalenguyen
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
setup_loggingincli/log.py, and the legacy_configure_loggerincli/_legacy.py, set thelivekitlogger to WARNING and then give a level only to the loggers of registered plugins that pass one. phonic never callsPlugin.register_plugin, and baseten registersBasetenPluginwithout itslogger, solivekit.plugins.phonicandlivekit.plugins.basetenstay at the inherited WARNING. Every debug and info line from both plugins is dropped, with--log-level debugas well as at the default INFO ofstart(phonic'sPhonic Conversation began with ID: ...is one of them), while the same flags work for plugins like deepgram. phonic is also missing from the worker'splugin registeredstartup lines.Changes
phonic now registers a
PhonicPluginwith its logger, and baseten passes its already importedloggertoPlugin.__init__, so both loggers follow the CLI log level like the other plugins. phonic's twolk.pii.*tagged lines now show up at their levels as well: typed user text at INFO, and system messages added mid-session at DEBUG.