Skip to content

fix(phonic, baseten): register plugin loggers so debug/info logs show up - #8007

Merged
tinalenguyen merged 1 commit into
livekit:mainfrom
omChauhanDev:fix/phonic-baseten-plugin-loggers
Oct 21, 2026
Merged

tinalenguyen merged 1 commit into
livekit:mainfrom
omChauhanDev:fix/phonic-baseten-plugin-loggers

Conversation

@omChauhanDev

Copy link
Copy Markdown
Contributor

Problem

setup_logging in cli/log.py, and the legacy _configure_logger in cli/_legacy.py, set the livekit logger to WARNING and then give a level only to the loggers of registered plugins that pass one. phonic never calls Plugin.register_plugin, and baseten registers BasetenPlugin without its logger, so livekit.plugins.phonic and livekit.plugins.baseten stay at the inherited WARNING. Every debug and info line from both plugins is dropped, with --log-level debug as well as at the default INFO of start (phonic's Phonic Conversation began with ID: ... is one of them), while the same flags work for plugins like deepgram. phonic is also missing from the worker's plugin registered startup lines.

Changes

phonic now registers a PhonicPlugin with its logger, and baseten passes its already imported logger to Plugin.__init__, so both loggers follow the CLI log level like the other plugins. phonic's two lk.pii.* tagged lines now show up at their levels as well: typed user text at INFO, and system messages added mid-session at DEBUG.

phonic never registered itself and baseten registered without its logger, so the CLI never set a level on either logger and both stayed at the inherited WARNING.
@omChauhanDev
omChauhanDev requested a review from a team as a code owner October 21, 2026 03:06

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment on lines +11 to +13
class PhonicPlugin(Plugin):
def __init__(self) -> None:
super().__init__(__name__, __version__, __package__, logger)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟑 Phonic plugin registration lacks required documentation

Adding PhonicPlugin without documenting its class or initializer violates the repository's documentation requirement for new classes and methods.

Suggested change
class PhonicPlugin(Plugin):
def __init__(self) -> None:
super().__init__(__name__, __version__, __package__, logger)
class PhonicPlugin(Plugin):
"""Register the Phonic provider with the LiveKit Agents plugin system."""
def __init__(self) -> None:
"""Initialize the plugin metadata and logger."""
super().__init__(__name__, __version__, __package__, logger)

Devin Review


Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

Comment on lines +13 to +16
super().__init__(__name__, __version__, __package__, logger)


Plugin.register_plugin(PhonicPlugin())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŸ₯ Phonic conversation text reaches unredacted stdout

With CLI logging at INFO or DEBUG, PhonicPlugin enables user text or system prompts to reach stdout. The CLI formatters print lk.pii.* fields without redaction, even when project redaction is enabled.

Devin Review


Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

@tinalenguyen
tinalenguyen merged commit adf963b into livekit:main Oct 21, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants