refactor: record URL mappings during parsing - #138
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes duplicate URL parsing and decoding.
It also reduces duplicated parser semantics.
Validation
pnpm test: 1978 tests passed.pnpm run lintpassed.pnpm run buildpassed.node scripts/bench-source-map.mjs --smokepassed.node scripts/bench-parse.mjs --smokepassed with AST parity.Benchmark
GitHub CI measured 696.31 ms for the 512 KiB URL case.
The CI growth ratio was 3.97x from 128 KiB to 512 KiB.
This keeps near-linear growth without a wall-time regression.
A local run measured 461.69 ms and a 3.61x growth ratio.