LCORE-5254: Restrict Fullsend retro to explicit /fs-retro comments by anik120 · Pull Request #3074 · lightspeed-core/lightspeed-stack

anik120 · 2026-10-29T17:52:12Z

Description

Prevent the retro agent from running automatically on every closed pull request. Instead, only trigger retro on explicit /fs-retro comments from humans. This avoids unnecessary retro runs and potential side effects from automated workflows.

Before this change:

Retro runs on every PR close (merged or not)
Can add labels or create issues as side effects
Adds noise to closed PRs

After this change:

Retro only runs on explicit /fs-retro comment (opt-in)
Manual retrospective requests still work via /fs-retro

Implemented via documented CEL trigger from Fullsend config reference. https://fullsend.sh/docs/guides/user/customizing-agents#choosing-when-retro-runs

Type of change

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

New Features
- Added a /fs-retro command that starts a retrospective when included in a human-authored comment during a transition.

Prevent the retro agent from running automatically on every closed pull request. Instead, only trigger retro on explicit /fs-retro comments from humans. This avoids unnecessary retro runs and potential side effects from automated workflows. Before this change: - Retro runs on every PR close (merged or not) - Can add labels or create issues as side effects - Adds noise to closed PRs After this change: - Retro only runs on explicit /fs-retro comment (opt-in) - Manual retrospective requests still work via /fs-retro Implemented via documented CEL trigger from Fullsend config reference. https://fullsend.sh/docs/guides/user/customizing-agents#choosing-when-retro-runs Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>

coderabbitai · 2026-10-29T17:52:27Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: lightspeed-core/lightspeed-stack
Branch: main
File: .coderabbit.yaml
Commit: 401a7b5
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 0306bf0c-413e-486f-abdd-b5d44d9e3694

Commits

Reviewing files that changed from the base of the PR and between 401a7b5 and 0cd7658.

Files selected for processing: 1

.fullsend/config.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 24

GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
GitHub Check: check_dependencies
GitHub Check: bandit
GitHub Check: Pylinter
GitHub Check: integration_tests (3.14)
GitHub Check: integration_tests (3.12)
GitHub Check: integration_tests (3.13)
GitHub Check: pydocstyle
GitHub Check: spectral
GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: mypy
GitHub Check: black
GitHub Check: build-pr
GitHub Check: shellcheck
GitHub Check: unit_tests (3.14)
GitHub Check: unit_tests (3.13)
GitHub Check: unit_tests (3.12)
GitHub Check: ruff
GitHub Check: radon
GitHub Check: dispatch / Harness dispatch
GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
GitHub Check: authorize / Check repository owner or member
GitHub Check: check

Additional comments: 1

.fullsend/config.yaml: 1

13-18: LGTM!

Walkthrough

The Fullsend configuration adds a retro role trigger for human-authored comments that use /fs-retro.

Changes

Retro trigger

Layer / File(s)	Summary
Configure retro role trigger `.fullsend/config.yaml`	The `retro` role triggers on comment-added transitions when the actor is human and the comment command is `/fs-retro`.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

lightspeed-core/lightspeed-stack#3070: Changes the Fullsend review role to use a human /fs-review comment trigger.
lightspeed-core/lightspeed-stack#3055: Introduces the Fullsend configuration and enables the retro role.

Suggested reviewers: tisnik, jrobertboos

Merge Risk: Minimal · up to 0cd76

The opt-in retro trigger is correctly configured and introduces no identified merge-blocking risk.

Pre-merge checks: 7

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the main change: the Fullsend retro now runs only on explicit /fs-retro comments. The raw summary confirms a retro role trigger that matches human-authored comments with the /fs-retro …
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity		PASSED. The pull request changes only `.fullsend/config.yaml` and adds a bounded CEL trigger expression. It introduces no loops, API calls, list operations, parsing work, caches, watchers, buffers, or…
Security And Secret Handling		PASSED. The pull request changes only `.fullsend/config.yaml` by adding a human-only `/fs-retro` comment trigger at lines 13-18. It adds no plaintext secret, token, endpoint, API response, log stateme…

Full details: Title check

Explanation

The title names the main change: the Fullsend retro now runs only on explicit /fs-retro comments. The raw summary confirms a retro role trigger that matches human-authored comments with the /fs-retro command. The objectives state the retro no longer runs automatically when a pull request closes. The title is specific, concise, and uses the ticket prefix common in this repository. It is 66 characters, which is within a normal title length.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Performance And Algorithmic Complexity

Explanation

PASSED. The pull request changes only .fullsend/config.yaml and adds a bounded CEL trigger expression. It introduces no loops, API calls, list operations, parsing work, caches, watchers, buffers, or unbounded data growth. No meaningful performance regression is present.

Full details: Security And Secret Handling

Explanation

PASSED. The pull request changes only .fullsend/config.yaml by adding a human-only /fs-retro comment trigger at lines 13-18. It adds no plaintext secret, token, endpoint, API response, log statement, command construction, path handling, Kubernetes Secret, or RH Secret. Existing workflow secret references and the WIF provider are unchanged.

Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

✨ Simplify code

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

tisnik

LGTM

fullsend-ai-retro · 2026-10-29T20:06:40Z

🤖 Finished Retro · ✅ Success · Started 8:06 PM UTC · Completed 8:15 PM UTC

Commit: 0cd7658 · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.32

fullsend-ai-retro · 2026-10-29T20:15:43Z

Retro for PR #3074 — Clean workflow, no proposals.

PR #3074 is a human-authored, config-only change (+6 lines to .fullsend/config.yaml) that restricts the retro agent to manual /fs-retro invocation. The workflow was straightforward:

No agent work dispatched — all agent roles (review, code, fix, triage) were correctly skipped by the Route job. This is appropriate for a .fullsend/ config change.
One human review — tisnik approved. The change is small and correctly implements a documented CEL trigger pattern.
All 18 CI checks passed on first push.
Merged in ~2 hours with zero rework.

Bootstrap note: This retro itself was dispatched automatically on merge — the old config (without the retro trigger restriction) was in effect when the pull_request_target event fired. Future merges will use the new config and will not trigger automatic retro. This is expected one-time behavior.

Broader context: The repo installed fullsend on Oct 28 (PR #3055). Within 24 hours, automatic retro runs filed 5 issues (#3063–3069). The team is calibrating agent autonomy by restricting retro (this PR, merged) and review (PR #3070, open) to manual invocation. This is a natural onboarding calibration step. Related platform concern: fullsend-ai/fullsend#8912 tracks tightening retro authorization for closed PRs.

Autonomy readiness: Inconclusive — no agent review ran, and the human approved without detailed inline comments, so no agent-vs-human delta can be computed.

tisnik approved these changes Oct 29, 2026

View reviewed changes

tisnik merged commit 2a17827 into lightspeed-core:main Oct 29, 2026
56 checks passed

anik120 mentioned this pull request Oct 30, 2026

LCORE-5254: Fix Fullsend config parse break from retro trigger #3087

Open

20 tasks

Navigation Menu

Repository navigation

LCORE-5254: Restrict Fullsend retro to explicit /fs-retro comments - #3074

LCORE-5254: Restrict Fullsend retro to explicit /fs-retro comments#3074
tisnik merged 1 commit into
lightspeed-core:mainfrom
anik120:disable-automatic-retro-fullsend

anik120 commented Oct 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

tisnik left a comment

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

fullsend-ai-retro Bot commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

anik120 commented Oct 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Tools used to create PR

Related Tickets & Documents

Checklist before requesting a review

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

tisnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anik120 commented Oct 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-retro Bot commented Oct 29, 2026 •

edited

Loading