feat: add architect for domain-specific review model selection - #110
Merged
lidge-jun merged 5 commits intoSep 9, 2026
Merged
Conversation
Separate architecture proposals and plan alignment from independent reviewer audits. Add configurable native architect dispatch and explicit safe registration while preserving main-agent judgment and existing settings.
Keep upstream Added and Fixed entries alongside architect Changed notes. Remove identical duplicate badge conflict blocks inherited in the three upstream READMEs.
thisisjun786
marked this pull request as ready for review
September 9, 2026 04:50
Preserve architect consultation and per-role fallback; route installed dispatch to the protocol and record native scenario verification.
lidge-jun
added a commit
to thisisjun786/codexclaw
that referenced
this pull request
Sep 9, 2026
…le-registration Keep lidge-jun#110's shared registrar (registerRole) and architect mapping; keep lidge-jun#91's executor resolution: executor spawns use the registered native executor type when $CODEX_HOME/agents/executor.toml exists, otherwise the built-in worker. Tests from both sides retained; dist rebuilt; badges regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Architecture proposals and adversarial correctness reviews currently share one reviewer configuration. Add an independently configurable
architectrole while keeping executable plans and final decisions with the main agent.Formal P follows: main gathers evidence → architect proposes design → main writes the plan → the same architect checks alignment → an independent reviewer audits it. This is agent-followed workflow guidance. Small C0/C1 edits retain the existing fast path.
Changes
agent_type: "architect"through dispatch and provide explicitcxc subagents register architect. Registration preserves existing custom role files; restart Codex to expose a newly registered role.dev, including first-fallback support, retaining both CLI registration and fallback controls. Extend MCP fallback coverage to canonicalROLES.bin/cxc.mjsnow routessubagents dispatchto the fallback protocol, matching the repository CLI. Add regression coverage to the existing payload test.Validation
After integrating
devat1ca63c86772d9860fd00f0373f2b092bc01557bd, the complete local suite passed: 2,824 passed, 0 failed, 72 skipped (2,896 total). Published counts and drift gate agree.Component build, GUI build/typecheck, Linux platform smoke and inventory/drift checks passed during integration. The installed CLI correction additionally passed all three payload dispatcher tests.
Fresh native Codex runs against isolated fixtures exercised:
ALIGNEDreflection, and obtained PASS from a separate reviewer.The tested architect and reviewer both inherited the parent's workspace-write permissions in this host. Architect remains advisory by role instructions, consistent with existing reviewer behavior; these tests do not claim a separately enforced filesystem sandbox. Requested model/effort values and actual child IDs were recorded. No provider failure was injected, so live primary-to-fallback transition is not claimed.
See
devlog/_fin/260909_architect_native/020_dev_integration.mdand030_live_scenarios.mdfor evidence and limitations. The feature and installed-CLI correction were applied to the maintainer's local plugin with source and rollback backups; this PR does not publish a release.Integration note
This targets
devdirectly. It overlaps #91 in the shared native-role registrar and executor guidance; reconcile those changes if both proposals are adopted. Architect does not alias itself to explorer/reviewer when its native role is unavailable.