Skip to content

Avoid AnalyticFunction segfaults in debug mode by asserting valid pointers #4445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwpeterson merged 2 commits into from
Apr 29, 2026
+8 −2
Merged

Avoid AnalyticFunction segfaults in debug mode by asserting valid pointers #4445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50864ee
AnalyticFunction: Assert that relevant function pointer is non-nullpt…
jwpeterson Apr 29, 2026
fc0e1bc
Add messages to the asserts
jwpeterson Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/numerics/analytic_function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ inline
Output AnalyticFunction<Output>::operator() (const Point & p,
const Real time)
{
libmesh_assert (this->initialized());
libmesh_assert(this->initialized());
libmesh_assert_msg(_number_fptr,
"You must construct AnalyticFunction with a scalar-valued "
"function in order to use this operator() override.");
return (this->_number_fptr(p, time));
}

Expand All @@ -123,7 +126,10 @@ void AnalyticFunction<Output>::operator() (const Point & p,
const Real time,
DenseVector<Output> & output)
{
libmesh_assert (this->initialized());
libmesh_assert(this->initialized());
libmesh_assert_msg(_vector_fptr,
"You must construct AnalyticFunction with a vector-valued "
"function in order to use this operator() override.");
this->_vector_fptr(output, p, time);
return;
}
Expand Down