Avoid AnalyticFunction segfaults in debug mode by asserting valid pointers#4445
Open
jwpeterson wants to merge 2 commits intolibMesh:develfrom
Open
Avoid AnalyticFunction segfaults in debug mode by asserting valid pointers#4445jwpeterson wants to merge 2 commits intolibMesh:develfrom
jwpeterson wants to merge 2 commits intolibMesh:develfrom
Conversation
…r before using It is currently possible to construct an AnalyticFunction with either an OutputFunction pointer or an OutputVectorFunction pointer, but System::reinit_constraints() expects to be able to use the void-returning AnalyticFunction::operator(), which in turn uses _vector_fptr without first asserting it is valid. I guess we never did this combination of things before, but it came up for me recently in an example created by claude. Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt (gdb) f 1 127 this->_vector_fptr(output, p, time); (gdb) p _vector_fptr $1 = (libMesh::AnalyticFunction<double>::OutputVectorFunction) 0x0
roystgnr
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two ways of constructing an
AnalyticFunction(either with a scalar-valued or a vector-valued function), butSystem::reinit_constraints()expects to be able to use the latter. Previously, it was a segfault even in debug mode when you attempted to use a scalar-valuedAnalyticFunction. With this patch, at least in debug mode, we now get an assert with a more informative error message.