Fix logging placeholders missing their arguments - #723
Open
Julia-b-work wants to merge 1 commit into
Open
Julia-b-work wants to merge 1 commit into
Julia-b-work wants to merge 1 commit into
Conversation
Two logger.debug calls carried a %s placeholder but passed no argument, so they logged the literal '%s' text instead of the value. - base.py: 'Job %s complete' now passes res.name - dream.py: 'Variable %s is outside of bounds' now passes k.name Fixes lanl#715 Signed-off-by: julia-b-work <juliabarrioswork@gmail.com>
Collaborator
|
Thanks, this is correct and CI is green. #717 opened about 50 minutes earlier with an identical diff, so it goes first. No reflection on your work. The matching diff is expected. Issue #715 quoted both replacement lines exactly, so anyone working from it writes this same patch. I'm leaving this open. #717 has an open question its author needs to settle first. If that doesn't happen, we merge yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two logger.debug calls carried a %s placeholder but passed no argument, so they logged the literal '%s' text instead of the value.
Fixes #715