Skip to content

fix: include values in diagnostic log messages - #717

Open
Voyagerroc-Lab wants to merge 1 commit into
lanl:mainfrom
Voyagerroc-Lab:fix/715-logging-format-args
Open

Voyagerroc-Lab wants to merge 1 commit into
lanl:mainfrom
Voyagerroc-Lab:fix/715-logging-format-args

Conversation

@Voyagerroc-Lab

Copy link
Copy Markdown

Summary

  • include the completed job name in the algorithm success log
  • include the bounded parameter name in DREAM rejection logs

Fixes #715

Testing

  • python -m compileall -q pybnf/algorithms/base.py pybnf/algorithms/samplers/dream.py
  • targeted logging-format scan passes for the changed calls
  • git diff --check passes

Signed-off-by: Voyagerroc-Code <325343927+Voyagerroc-Code@users.noreply.github.com>
@wshlavacek

wshlavacek commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks, this is correct and CI is green.

One thing blocks the merge. PyBNF takes contributions under the Developer Certificate of Origin, so the Signed-off-by: line needs to identify the person submitting the work. This commit is authored, committed, and signed off as:

Voyagerroc-Code <325343927+Voyagerroc-Code@users.noreply.github.com>

That account returns 404 on the web and on both API lookups, and it isn't the account that opened this PR. The sign-off points at an identity we can't verify.

Could you re-commit under your own identity and sign off with it?

git commit --amend --author="Your Name <your@email>" -s --no-edit
git push --force

A @users.noreply.github.com address for your own account works fine. It just needs to resolve to you.

For transparency, an identical fix came in later as #723. Yours was first and I'd rather merge yours, so this is the only thing in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two logging calls have a %s with no argument, so they log the literal placeholder (DREAM drops the out-of-bounds parameter name)

2 participants