fix: include values in diagnostic log messages - #717
Open
Voyagerroc-Lab wants to merge 1 commit into
Open
Voyagerroc-Lab wants to merge 1 commit into
Voyagerroc-Lab wants to merge 1 commit into
Conversation
Signed-off-by: Voyagerroc-Code <325343927+Voyagerroc-Code@users.noreply.github.com>
Collaborator
|
Thanks, this is correct and CI is green. One thing blocks the merge. PyBNF takes contributions under the Developer Certificate of Origin, so the That account returns 404 on the web and on both API lookups, and it isn't the account that opened this PR. The sign-off points at an identity we can't verify. Could you re-commit under your own identity and sign off with it? git commit --amend --author="Your Name <your@email>" -s --no-edit
git push --forceA For transparency, an identical fix came in later as #723. Yours was first and I'd rather merge yours, so this is the only thing in the way. |
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #715
Testing