Skip to content

feat(sdk,mcp,server,ui): meeting block contract — catalogue, schemas, MCP surface (MEET-4) - #368

Closed
eliotlim wants to merge 4 commits into
feat/meet-2-transcribefrom
feat/meet-4-meeting-catalogue
Closed

eliotlim wants to merge 4 commits into
feat/meet-2-transcribefrom
feat/meet-4-meeting-catalogue

Conversation

@eliotlim

@eliotlim eliotlim commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Problem

The meeting block needed a typed, drift-guarded contract across sdk/mcp/server/ui before UI work could start. Board: MEET-4.

Solution

Registers meeting (kit, container, kitValue:false) in the single-source catalogue with full prop schemas: status enum, audioChunks [{assetId,durationMs,startedAtMs?}], transcript [{startMs,endMs,text}] (endMs>=startMs runtime refine), summary, startedAt, title — strict nested objects, passthrough top level. Adds shared invalidBlockTreeProps so MCP create/append/insert and agent add_blocks validate props recursively (previously update-only — same shared schema code, no divergence). Minimal placeholder kit renderer in editor+viewer hosts (replaced by MEET-5). Docs: mcp README prop table, regenerated coverage matrix (45 types, zero exemptions), docs/meeting-block.md. No new deps.

Before / After

Behavior Before After
list_block_types no meeting meeting + propsSchema — blockTypes.test.mts (67 checks)
add_blocks with malformed declared props accepted at creation rejected (shared validator) — blockCatalogue.test.ts (16 negative cases), agentBlockTypes.test.ts
Page containing a meeting block n/a renders placeholder (title/status/note count); no crash in diff/export paths

No visual change (placeholder only, no slash entry until MEET-5).

Test procedure

pnpm verify (sdk 565, ui 2320, server 1327, full MCP matrix; e2e 256+70). Targeted: pnpm --filter @book.dev/sdk vitest run src/blockCatalogue.test.ts.

Operational notes

No env/migration. Creation-path validation is a deliberate tightening: payloads with malformed DECLARED props now fail at creation (update path already rejected them since API-11). Merge after #366/MEET-2 PR (shared OIDC fixture hunk, comment-only conflict). MEET-5 PR stacks on this.


Verify: green. Reviews cleared: code (Quinn). Conditions honored: full scope in this title; worker docs stripped; export cases + schema typing tracked (MEET-5 shipped the export cases; MEET-10 tracks transcriptionCompleted typing).

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
app.book.pub Canceled Canceled Oct 4, 2026 2:14pm UTC

Request Review

# Conflicts:
#	packages/server/src/ableOidc.test.ts

This branch was previously deployed

1 inactive deployment
Preview — 90825279 Deployed Oct 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant