Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # packages/server/src/ableOidc.test.ts
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The meeting block needed a typed, drift-guarded contract across sdk/mcp/server/ui before UI work could start. Board: MEET-4.
Solution
Registers
meeting(kit, container, kitValue:false) in the single-source catalogue with full prop schemas:statusenum,audioChunks [{assetId,durationMs,startedAtMs?}],transcript [{startMs,endMs,text}](endMs>=startMs runtime refine),summary,startedAt,title— strict nested objects, passthrough top level. Adds sharedinvalidBlockTreePropsso MCP create/append/insert and agent add_blocks validate props recursively (previously update-only — same shared schema code, no divergence). Minimal placeholder kit renderer in editor+viewer hosts (replaced by MEET-5). Docs: mcp README prop table, regenerated coverage matrix (45 types, zero exemptions),docs/meeting-block.md. No new deps.Before / After
list_block_typesblockTypes.test.mts(67 checks)blockCatalogue.test.ts(16 negative cases),agentBlockTypes.test.tsNo visual change (placeholder only, no slash entry until MEET-5).
Test procedure
pnpm verify(sdk 565, ui 2320, server 1327, full MCP matrix; e2e 256+70). Targeted:pnpm --filter @book.dev/sdk vitest run src/blockCatalogue.test.ts.Operational notes
No env/migration. Creation-path validation is a deliberate tightening: payloads with malformed DECLARED props now fail at creation (update path already rejected them since API-11). Merge after #366/MEET-2 PR (shared OIDC fixture hunk, comment-only conflict). MEET-5 PR stacks on this.
Verify: green. Reviews cleared: code (Quinn). Conditions honored: full scope in this title; worker docs stripped; export cases + schema typing tracked (MEET-5 shipped the export cases; MEET-10 tracks
transcriptionCompletedtyping).🤖 Generated with Claude Code