Repository navigation
ci: add shared release fix notifications - #1533
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes add a workflow that invokes a pinned reusable workflow for release fixes. It supports release events and manual dispatches. The CLI publishing workflow also invokes it after a successful, uncancelled release on a version tag. ChangesRelease fix comments
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The notification paths have the required permissions and release guard. No concrete issue identified here prevents merging after the planned checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| comment-release-fixes: | ||
| needs: release | ||
| if: ${{ !cancelled() && needs.release.result == 'success' && startsWith(github.ref, 'refs/tags/v') }} |
There was a problem hiding this comment.
A manual publish-cli run on a v* tag skips publication, but the successful release job still lets comment-release-fixes run without a dry_run input. If the shared workflow does not block draft releases, this can send comments before the release is public. Exclude workflow_dispatch here, or require an output from the publication step.
| if: ${{ !cancelled() && needs.release.result == 'success' && startsWith(github.ref, 'refs/tags/v') }} | |
| if: ${{ !cancelled() && github.event_name != 'workflow_dispatch' && needs.release.result == 'success' && startsWith(github.ref, 'refs/tags/v') }} |
1 participant
https://entire.io/gh/jdx/usage/trails/78
Summary
Add shared release-fix notifications through jdx/workflows, with a manual dry-run/recovery entry point.
Call the shared workflow after publication so token-created releases do not depend on a suppressed downstream release event.
Dependency and validation
Depends on jdx/workflows#4 and pins its implementation by immutable SHA. This is a draft rollout PR: shared-code safety review and project-specific publication-path validation are still in progress. No live notification dispatch or historical backfill is part of this PR. Do not merge until the shared dependency and relevant checks are settled.
Note
Low Risk
Changes are limited to GitHub Actions (comments on issues/PRs after release); no application runtime or auth logic is modified.
Overview
Adds release-fix notification automation by wiring in the shared
jdx/workflowscomment-release-fixesworkflow (pinned to SHA4c952564…), using marker prefixusage-fixed-in.A new standalone workflow runs on
release: publishedor manual dispatch (requiredtag, optionaldry_rundefaulting to true).publish-cli.ymlalso runs the same reusable workflow after a successful version-tagreleasejob so fixes are commented even when the normal release event path is unreliable.Minor CI hygiene: artifact action comments in
perf-pr.ymlandperf.ymlare updated to# v7.0.1/# v8.0.1(same commit SHAs).Reviewed by Cursor Bugbot for commit f8aa4f3. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit