Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Libraries for Java 32.0.1-jre API. For more information, see documentation here:

This package includes supporting Inductive Automation's classes and interfaces.
For more information, see documentation here:
<https://sdk.inductiveautomation.com/javadoc/ignition83/8.3.8/index.html>.
<https://sdk.inductiveautomation.com/javadoc/ignition83/8.3.9/index.html>.

#### org.apache

Expand Down Expand Up @@ -133,7 +133,7 @@ This package includes supporting classes and interfaces from Mongo Java driver

This package includes supporting classes and interfaces from the Inductive
Automation's `org.json` package, see documentation here:
<https://sdk.inductiveautomation.com/javadoc/ignition83/8.3.8/org/json/package-summary.html>
<https://sdk.inductiveautomation.com/javadoc/ignition83/8.3.9/org/json/package-summary.html>

#### org.python

Expand Down
4 changes: 2 additions & 2 deletions src/system/__version__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Package information."""

__version__ = "8.3.8"
__build__ = "2026071409"
__version__ = "8.3.9"
__build__ = "2026082511"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (broader_impact): The package metadata still declares version 8.3.8 in setup.cfg, while the runtime __version__ is changed to 8.3.9, so building the main package produces an 8.3.8 distribution despite reporting 8.3.9 at runtime. The stubs package metadata in stubs/pyproject.toml and the release configuration in .cz.toml likewise remain at 8.3.8.

Triggers: When the package or stubs are built or published from this commit.

Suggested fix: Update every packaging and release-version source, including setup.cfg, stubs/pyproject.toml, and .cz.toml, to 8.3.9.

19 changes: 0 additions & 19 deletions src/system/historian/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,9 @@ def queryAggregatedPoints(
startTime=None, # type: Optional[Date]
endTime=None, # type: Optional[Date]
aggregates=None, # type: Optional[List[Union[str, unicode]]]
fillModes=None, # type: Optional[List[Union[str, unicode]]]
columnNames=None, # type: Optional[List[Union[str, unicode]]]
returnFormat="Wide", # type: str
returnSize=1, # type: int
includeBounds=False, # type: bool
excludeObservations=False, # type: bool
):
# type: (...) -> BasicDataset
"""Queries aggregated data points for the specified historian.
Expand All @@ -79,15 +76,10 @@ def queryAggregatedPoints(
endTime: An end time to query aggregated data points for.
aggregates: A list of aggregate functions to apply to the query.
Optional.
fillModes: A list of fill modes to apply to the query. Optional.
columnNames: A list of alias column names for the returned
dataset. Optional.
returnFormat: The desired return format for the query. Optional.
returnSize: The number maximum of results to return. Optional.
includeBounds: Whether to include the bounds in the query
results. Optional.
excludeObservations: Whether to exclude observed aggregated data
points in the query results. Optional.

Returns:
A dataset representing the aggregated points for the specified
Expand All @@ -98,12 +90,9 @@ def queryAggregatedPoints(
startTime,
endTime,
aggregates,
fillModes,
columnNames,
returnFormat,
returnSize,
includeBounds,
excludeObservations,
)
return BasicDataset()

Expand Down Expand Up @@ -161,8 +150,6 @@ def queryRawPoints(
columnNames=None, # type: Optional[List[Union[str, unicode]]]
returnFormat="Wide", # type: str
returnSize=-1, # type: int
includeBounds=False, # type: bool
excludeObservations=False, # type: bool
):
# type: (...) -> BasicDataset
"""Queries raw data points for the specified Historian.
Expand All @@ -176,10 +163,6 @@ def queryRawPoints(
dataset. Optional.
returnFormat: The desired return format for the query. Optional.
returnSize: The maximum number of results to return. Optional.
includeBounds: Whether to include the bounds in the query
results. Optional.
excludeObservations: Whether to exclude observed raw data points
in the query results. Optional.

Returns:
A dataset representing the raw data points for the specified
Expand All @@ -192,8 +175,6 @@ def queryRawPoints(
columnNames,
returnFormat,
returnSize,
includeBounds,
excludeObservations,
)
return BasicDataset()

Expand Down
5 changes: 0 additions & 5 deletions stubs/stubs/system/historian/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@ def queryAggregatedPoints(
startTime: Optional[Date] = ...,
endTime: Optional[Date] = ...,
aggregates: Optional[List[Union[str, unicode]]] = ...,
fillModes: Optional[List[Union[str, unicode]]] = ...,
columnNames: Optional[List[Union[str, unicode]]] = ...,
returnFormat: str = ...,
returnSize: int = ...,
includeBounds: bool = ...,
excludeObservations: bool = ...,
) -> BasicDataset: ...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The repository contains a second system/historian.pyi stub that still declares the removed fillModes, includeBounds, and excludeObservations parameters, so type checking can expose a stale historian interface that disagrees with the updated implementation and package stub.

Triggers: When a type checker resolves system.historian through the top-level historian.pyi module stub rather than the updated package stub.

Suggested fix: Remove the obsolete parameters from stubs/stubs/system/historian.pyi as well, or remove the duplicate conflicting stub file if it is not intended to be distributed.

def queryAnnotations(
paths: List[Union[str, unicode]],
Expand All @@ -39,8 +36,6 @@ def queryRawPoints(
columnNames: Optional[List[Union[str, unicode]]] = ...,
returnFormat: str = ...,
returnSize: int = ...,
includeBounds: bool = ...,
excludeObservations: bool = ...,
) -> BasicDataset: ...
def storeAnnotations(*args: Any, **kwargs: Any) -> List[BasicQualifiedValue]: ...
def storeDataPoints(*args: Any, **kwargs: Any) -> List[BasicQualifiedValue]: ...
Expand Down
Loading