chore: release 8.3.9 - #70
Conversation
- browse: remove snapshotTime - queryAggregatedPoints: fillPoints, includeBounds and excludeObservations - queryRawPoints: includeBounds and excludeObservations See: https://docs.inductiveautomation.com/docs/8.3/new-in-this-version#new-in-839
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePrepares the package for the 8.3.9 release and simplifies historian query interfaces by removing deprecated parameters consistently from implementations, documentation, and type stubs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/system/__version__.py" line_range="4" />
<code_context>
-__version__ = "8.3.8"
-__build__ = "2026071409"
+__version__ = "8.3.9"
+__build__ = "2026082511"
</code_context>
<issue_to_address>
**issue (broader_impact):** The package metadata still declares version 8.3.8 in `setup.cfg`, while the runtime `__version__` is changed to 8.3.9, so building the main package produces an 8.3.8 distribution despite reporting 8.3.9 at runtime. The stubs package metadata in `stubs/pyproject.toml` and the release configuration in `.cz.toml` likewise remain at 8.3.8.
**Triggers:** When the package or stubs are built or published from this commit.
**Suggested fix:** Update every packaging and release-version source, including `setup.cfg`, `stubs/pyproject.toml`, and `.cz.toml`, to 8.3.9.
</issue_to_address>
### Comment 2
<location path="stubs/stubs/system/historian/__init__.pyi" line_range="20" />
<code_context>
returnSize: int = ...,
- includeBounds: bool = ...,
- excludeObservations: bool = ...,
) -> BasicDataset: ...
def queryAnnotations(
paths: List[Union[str, unicode]],
</code_context>
<issue_to_address>
**issue (bug_risk):** The repository contains a second `system/historian.pyi` stub that still declares the removed `fillModes`, `includeBounds`, and `excludeObservations` parameters, so type checking can expose a stale historian interface that disagrees with the updated implementation and package stub.
**Triggers:** When a type checker resolves `system.historian` through the top-level `historian.pyi` module stub rather than the updated package stub.
**Suggested fix:** Remove the obsolete parameters from `stubs/stubs/system/historian.pyi` as well, or remove the duplicate conflicting stub file if it is not intended to be distributed.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: src/system/__version__.py:4, stubs/stubs/system/historian/__init__.pyi:20
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| __version__ = "8.3.8" | ||
| __build__ = "2026071409" | ||
| __version__ = "8.3.9" | ||
| __build__ = "2026082511" |
There was a problem hiding this comment.
issue (broader_impact): The package metadata still declares version 8.3.8 in setup.cfg, while the runtime __version__ is changed to 8.3.9, so building the main package produces an 8.3.8 distribution despite reporting 8.3.9 at runtime. The stubs package metadata in stubs/pyproject.toml and the release configuration in .cz.toml likewise remain at 8.3.8.
Triggers: When the package or stubs are built or published from this commit.
Suggested fix: Update every packaging and release-version source, including setup.cfg, stubs/pyproject.toml, and .cz.toml, to 8.3.9.
| returnSize: int = ..., | ||
| includeBounds: bool = ..., | ||
| excludeObservations: bool = ..., | ||
| ) -> BasicDataset: ... |
There was a problem hiding this comment.
issue (bug_risk): The repository contains a second system/historian.pyi stub that still declares the removed fillModes, includeBounds, and excludeObservations parameters, so type checking can expose a stale historian interface that disagrees with the updated implementation and package stub.
Triggers: When a type checker resolves system.historian through the top-level historian.pyi module stub rather than the updated package stub.
Suggested fix: Remove the obsolete parameters from stubs/stubs/system/historian.pyi as well, or remove the duplicate conflicting stub file if it is not intended to be distributed.
1 participant
Summary by Sourcery
Release version 8.3.9 and align historian query interfaces with the current API.
Enhancements:
Documentation:
Chores: