Skip to content

fix(lora): only drop adapter from _merged_adapters when unfused from all components #14385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AloysJehwin wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −3
Open

fix(lora): only drop adapter from _merged_adapters when unfused from all components #14385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88fa75f
fix(lora): only drop adapter from _merged_adapters when unfused from …
AloysJehwin Aug 4, 2026
ff8dbce
Merge branch 'main' into fix/unfuse-lora-merged-adapters-sync
AloysJehwin Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/diffusers/loaders/lora_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,11 +669,21 @@ def unfuse_lora(self, components: list[str] | None = None, **kwargs):
if issubclass(model.__class__, (ModelMixin, PreTrainedModel)):
for module in model.modules():
if isinstance(module, BaseTunerLayer):
for adapter in set(module.merged_adapters):
if adapter and adapter in self._merged_adapters:
self._merged_adapters = self._merged_adapters - {adapter}
module.unmerge()

# Only remove an adapter from _merged_adapters once it is no longer
# physically merged in any remaining loadable component. Removing it
# on the first unfused component would desync the set when the adapter
# is still fused into other components.
remaining_merged: set[str] = set()
for component_name in self._lora_loadable_modules:
component_model = getattr(self, component_name, None)
if component_model is not None and issubclass(component_model.__class__, (ModelMixin, PreTrainedModel)):
for module in component_model.modules():
if isinstance(module, BaseTunerLayer):
remaining_merged.update(module.merged_adapters)
self._merged_adapters = self._merged_adapters & remaining_merged

def set_adapters(
self,
adapter_names: list[str] | str,
Expand Down
Loading