fix(lora): only drop adapter from _merged_adapters when unfused from all components - #14385
Open
AloysJehwin wants to merge 2 commits into
Open
fix(lora): only drop adapter from _merged_adapters when unfused from all components#14385AloysJehwin wants to merge 2 commits into
AloysJehwin wants to merge 2 commits into
Conversation
…all components Signed-off-by: Aloys Jehwin <aloysjehwin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14214
When
unfuse_lora(components=[...])is called with a subset of components, the current code removes the adapter from_merged_adaptersas soon as it's unfused from the first component — even if it's still physically fused into the others. Sonum_fused_loras/fused_lorasreport nothing fused while the remaining components silently still have the LoRA baked in.The fix: call
module.unmerge()as before, then recompute_merged_adaptersby scanning all loadable components for adapters that are still physically merged (viaBaseTunerLayer.merged_adapters). That way the set only loses an adapter once it's gone from everything.Verified with the reproduction script from the issue —
num_fused_lorascorrectly stays at 1 after unfusing onlytext_encoder, and the unet is confirmed still merged at the PEFT level.