Skip to content

codegen: resync cloud client from EF 5739f5dc - #6221

Open
heygen-rui-bot wants to merge 1 commit into
mainfrom
sync/hyperframes-codegen-5739f5dc
Open

heygen-rui-bot wants to merge 1 commit into
mainfrom
sync/hyperframes-codegen-5739f5dc

Conversation

@heygen-rui-bot

Copy link
Copy Markdown
Collaborator

Auto-generated PR: the HyperFrames cloud-render OpenAPI surface in experiment-framework changed. This PR regenerates the typed client in packages/cli/src/cloud/_gen/.

Generated by scripts/generate_hyperframes_cli_client.py.

Source commit: 5739f5dcddc24f2400d5c6cb57c5f62263c2b600
Triggered by: https://github.com/heygen-com/experiment-framework/commit/5739f5dcddc24f2400d5c6cb57c5f62263c2b600

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regeneration is faithful to the upstream schema, but it can't merge as is.

  • It removes page_motion_blur from CreateHyperframesRenderRequest, and packages/cli/src/commands/cloud/render.ts:814 and :843 still use it for cloud render --page-motion-blur. The required Typecheck job fails on exactly those two lines.
  • The field was added to the generated file by hand in #6087, and the upstream render API schema doesn't declare it, so every regeneration will strip it again. The fix belongs upstream: add page_motion_blur to the render request schema there, then let this job regenerate. Patching _gen/types.ts by hand again would only last until the next sync.
  • The required "Semantic PR title" check also fails because codegen isn't an allowed type. The generator's title template needs an allowed type such as chore(cli): ....

The failure_code doc comment change is fine. The CLI only prints failure_message, so it changes nothing at runtime.

Verdict: REQUEST_CHANGES
Reasoning: Two required checks are red, and merging would break the CLI typecheck because the regen drops a field the cloud render command still sends.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants