Skip to content

codegen: resync cloud client from EF cae4a192 - #5718

Open
heygen-rui-bot wants to merge 1 commit into
mainfrom
sync/hyperframes-codegen-cae4a192
Open

heygen-rui-bot wants to merge 1 commit into
mainfrom
sync/hyperframes-codegen-cae4a192

Conversation

@heygen-rui-bot

Copy link
Copy Markdown
Collaborator

Auto-generated PR: the HyperFrames cloud-render OpenAPI surface in experiment-framework changed. This PR regenerates the typed client in packages/cli/src/cloud/_gen/.

Generated by scripts/generate_hyperframes_cli_client.py.

Source commit: cae4a192cf3e234f38961519dbbb98af05decbb9
Triggered by: https://github.com/heygen-com/experiment-framework/commit/cae4a192cf3e234f38961519dbbb98af05decbb9

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resync is already on main: crf and request_id are both in packages/cli/src/cloud/_gen/types.ts there, and that's why the branch now conflicts. Merging it would only resolve to a no-op, so I'd close it.

Two things for the generator, since they'll hit every resync:

  • The codegen: title type fails the required Semantic PR title check. The allowed types are feat, fix, docs, style, refactor, perf, test, build, ci, chore and revert. Something like chore(cli): resync cloud client from … would pass.
  • The newer resync (#6221) removes page_motion_blur, which main added by hand in #6087 and which commands/cloud/render.ts uses, so its Typecheck is red. The field needs to go into the source API spec, or every regeneration will keep dropping it.

The Comments check failure here comes from generated docstrings raising the file's comment share. Leaving _gen/ out of that ratchet would avoid it, though that check isn't required.

Verdict: COMMENT
Reasoning: The PR's two fields are already on main, so it is superseded and conflicting. Closing it and fixing the generator's title type and spec is the useful action, not merging.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants