Repository navigation
codegen: resync cloud client from EF cae4a192 - #5718
Open
heygen-rui-bot wants to merge 1 commit into
Open
heygen-rui-bot wants to merge 1 commit into
heygen-rui-bot wants to merge 1 commit into
Conversation
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
This resync is already on main: crf and request_id are both in packages/cli/src/cloud/_gen/types.ts there, and that's why the branch now conflicts. Merging it would only resolve to a no-op, so I'd close it.
Two things for the generator, since they'll hit every resync:
- The
codegen:title type fails the required Semantic PR title check. The allowed types are feat, fix, docs, style, refactor, perf, test, build, ci, chore and revert. Something likechore(cli): resync cloud client from …would pass. - The newer resync (#6221) removes
page_motion_blur, which main added by hand in #6087 and whichcommands/cloud/render.tsuses, so its Typecheck is red. The field needs to go into the source API spec, or every regeneration will keep dropping it.
The Comments check failure here comes from generated docstrings raising the file's comment share. Leaving _gen/ out of that ratchet would avoid it, though that check isn't required.
Verdict: COMMENT
Reasoning: The PR's two fields are already on main, so it is superseded and conflicting. Closing it and fixing the generator's title type and spec is the useful action, not merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated PR: the HyperFrames cloud-render OpenAPI surface in experiment-framework changed. This PR regenerates the typed client in
packages/cli/src/cloud/_gen/.Generated by
scripts/generate_hyperframes_cli_client.py.Source commit: cae4a192cf3e234f38961519dbbb98af05decbb9
Triggered by: https://github.com/heygen-com/experiment-framework/commit/cae4a192cf3e234f38961519dbbb98af05decbb9