Skip to content

chore(librarian): use frozen lockfile and workspace for generator build - #9407

Draft
bshaffer wants to merge 1 commit into
consolidate-pnpm-lockfiles-pnpm-10from
librarian-frozen-lockfile-followup
Draft

bshaffer wants to merge 1 commit into
consolidate-pnpm-lockfiles-pnpm-10from
librarian-frozen-lockfile-followup

Conversation

@bshaffer

Copy link
Copy Markdown
Contributor

Use pnpm install --frozen-lockfile --ignore-scripts in librarian.yaml once the next gapic-generator tag is released after #9381.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build step in librarian.yaml to use pnpm install with --frozen-lockfile and --ignore-scripts. The reviewer notes that the package URL and checksum still point to the older v5.3.0 release and suggests verifying if a newer version is required for this command.

Comment thread librarian.yaml
checksum: 4bc54d399b22c845fd4555f9435b7971153a2e3fafca32402658390711828f63
build:
- pnpm install --ignore-workspace --no-frozen-lockfile --config.auto-install-peers=true
- pnpm install --frozen-lockfile --ignore-scripts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description indicates that pnpm install --frozen-lockfile --ignore-scripts should be used once the next gapic-generator tag is released. However, the package URL (line 25) and checksum (line 26) are still pointing to the older v5.3.0 release. Before flagging this version as invalid or outdated, please verify the version against other active repositories in the organization (e.g., google-cloud-go) to ensure consistency. If a newer version is indeed active and required for this command, please update the package version and checksum accordingly.

References
  1. When validating tool versions (such as protoc) in configuration files like librarian.yaml, verify the version against other active repositories in the organization (e.g., google-cloud-go) before flagging it as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant