Conversation
bshaffer
commented
Sep 18, 2026
bshaffer
commented
Contributor
- Consolidate nested pnpm-lock.yaml files (gapic-generator-typescript, gapic-node-processing, gapic-tools) into root pnpm-lock.yaml
- Upgrade librarian and generator workflows/tests to pnpm 10 and remove Bazel config from gapic-generator-typescript
# Conflicts: # pnpm-lock.yaml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes Bazel build configuration files and integrates the gapic-generator-typescript package directly into the pnpm workspace. It also updates TypeScript type assertions in generator.ts to resolve compilation issues and modifies the installation command in librarian.yaml. Feedback suggests removing the --force flag from the pnpm install command in librarian.yaml to prevent unnecessary slowdowns in the build pipeline.
…ignore-scripts to workflows
…files-pnpm-10 # Conflicts: # core/generator/gapic-generator-typescript/WORKSPACE # core/generator/gapic-generator-typescript/package.json # core/generator/gapic-generator-typescript/pnpm-lock.yaml
bshaffer
changed the title
bshaffer
changed the title
… root package.json
…rride to root package.json" This reverts commit 2cc19a6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.